luke
/
openFPGALoader
mirror of https://github.com/trabucayre/openFPGALoader.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a buffer overflow per code review

This commit is contained in:
phdussud 2021-06-19 12:39:25 -07:00
parent cbbac0bff8
commit 80f642a0a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/dirtyJtag.cpp
View File

@ -196,7 +196,7 @@ int DirtyJtag::writeTMS(uint8_t *tms, int len, bool flush_buffer)
buf[buffer_idx++] = CMD_SETSIG; buf[buffer_idx++] = CMD_SETSIG;
buf[buffer_idx++] = mask; buf[buffer_idx++] = mask;
buf[buffer_idx++] = val | SIG_TCK; buf[buffer_idx++] = val | SIG_TCK;
if ((buffer_idx + 7) >= sizeof(buf) || (i == len - 1)) { if ((buffer_idx + 9) >= sizeof(buf) || (i == len - 1)) {
//flush the buffer //flush the buffer
if (i == len - 1) { if (i == len - 1) {
//insert tck falling edge //insert tck falling edge
@ -209,7 +209,7 @@ int DirtyJtag::writeTMS(uint8_t *tms, int len, bool flush_buffer)
buf, buffer_idx, &actual_length, 1000); buf, buffer_idx, &actual_length, 1000);
if (ret < 0) if (ret < 0)
{ {
cerr << "toggleClk: usb bulk write failed " << ret << endl; cerr << "writeTMS: usb bulk write failed " << ret << endl;
return -EXIT_FAILURE; return -EXIT_FAILURE;
} }
buffer_idx = 0; buffer_idx = 0;