xilinx:cppcheck

This commit is contained in:
Gwenhael Goavec-Merou 2020-08-19 16:57:07 +02:00
parent 2b3c9f0f8f
commit 7e763dcc25
2 changed files with 5 additions and 5 deletions

View File

@ -10,7 +10,7 @@
#include "part.hpp" #include "part.hpp"
#include "progressBar.hpp" #include "progressBar.hpp"
Xilinx::Xilinx(Jtag *jtag, std::string filename, bool verbose): Xilinx::Xilinx(Jtag *jtag, const std::string &filename, bool verbose):
Device(jtag, filename, verbose) Device(jtag, filename, verbose)
{ {
if (_filename != ""){ if (_filename != ""){
@ -294,7 +294,7 @@ int Xilinx::spi_wait(uint8_t cmd, uint8_t mask, uint8_t cond,
break; break;
} }
if (verbose) { if (verbose) {
printf("%x %x %x %d\n", tmp, mask, cond, count); printf("%x %x %x %u\n", tmp, mask, cond, count);
} }
} while ((tmp & mask) != cond); } while ((tmp & mask) != cond);
_jtag->go_test_logic_reset(); _jtag->go_test_logic_reset();

View File

@ -10,14 +10,14 @@
class Xilinx: public Device, SPIInterface { class Xilinx: public Device, SPIInterface {
public: public:
Xilinx(Jtag *jtag, std::string filename, bool verbose); Xilinx(Jtag *jtag, const std::string &filename, bool verbose);
~Xilinx(); ~Xilinx();
void program(unsigned int offset = 0) override; void program(unsigned int offset = 0) override;
void program_spi(unsigned int offset = 0); void program_spi(unsigned int offset = 0);
void program_mem(BitParser &bitfile); void program_mem(BitParser &bitfile);
int idCode(); int idCode() override;
void reset(); void reset() override;
/* spi interface */ /* spi interface */
int spi_put(uint8_t cmd, uint8_t *tx, uint8_t *rx, int spi_put(uint8_t cmd, uint8_t *tx, uint8_t *rx,