luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "retain perl compatibility" 

this did reintroduce hundreds of warnings:
defined(%hash) is deprecated at ...ngspice/tests/bin/runQaTests.pl line 331.
	(Maybe you should just omit the defined()?)

this was deprecated aproximately 2001 with perl version
  v5.6.1

see
 https://perldoc.perl.org/perl561delta.html

obviously for good reason, because defined(%hash) did have a semantics which
  did not exactly match the users expectation.
This commit is contained in:
rlar 2017-08-13 18:00:42 +02:00
parent 608a1fc33d
commit ff4b8dcf41
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/bin/modelQaTestRoutines.pm
View File

@ -201,7 +201,7 @@ sub processTestSpec {
@main::ModelParameters=();
@main::TestVariants=@main::Variants;
undef(%main::BiasFor);
if (defined(%main::isGeneralFloatingPin)) {
if (%main::isGeneralFloatingPin) {
%main::isFloatingPin=%main::isGeneralFloatingPin;
} else {
undef(%main::isFloatingPin);

4
tests/bin/runQaTests.pl
View File

@ -329,7 +329,7 @@ if ($reallyVerbose) {
$flag="";
}
foreach $test (@Test) {
next if (defined(%doTest) && !$doTest{$test});
next if (%doTest && !$doTest{$test});
if ($verbose) {print "\n****** Running test ($simulatorName): $test"}
@ -343,7 +343,7 @@ foreach $test (@Test) {
} else {
$refFile="$resultsDirectory/$test.standard";
}
next if (defined(%doVariant) && !$doVariant{$variant});
next if (%doVariant && !$doVariant{$variant});
$simFile="$resultsDirectory/$test.$variant";
if ($outputDc) {
if (($forceSimulation || ! -r $simFile) && !$onlyDoComparison) {