luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add a correction to the previous change of inppas4.c, which freed devname and left instance name pointers in DEVnameHash pointing at freed memory. This commit adds the devname string to the symbol tables which are eventually cleared by INPtabEnd. Also, if a capacitor in the spice netlist has the same name (unlikely, but possible) as a shunt capacitor, then no shunt is created, and a warning is issued.

This commit is contained in:
Brian Taylor 2025-09-27 12:16:39 -07:00
parent 5e3d24e70d
commit e934d3dcef
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/spicelib/parser/inppas4.c
View File

@ -57,8 +57,24 @@ void INPpas4(CKTcircuit *ckt, INPtables *tab)
int nn = node->number;
char* devname = tprintf("capac%dshunt", nn);
(*(ft_sim->newInstance))(ckt, tab->defCmod, &fast, devname);
txfree(devname);
fast = (*(ft_sim->findInstance))(ckt, devname);
if (fast) {
fprintf(stderr,
"WARNING: non-cshunt instance %s already exists\n",
devname);
tfree(devname);
continue;
}
error = (*(ft_sim->newInstance))(ckt, tab->defCmod, &fast, devname);
if (error) {
fprintf(stderr,
"ERROR: cshunt newInstance status %d devname %s\n",
error, devname);
tfree(devname);
continue;
}
/* devname is eventually freed when INPtabEnd is called */
INPinsert(&devname, tab);
/* the top node, second node is gnd automatically */
(*(ft_sim->bindNode))(ckt, fast, 1, node);