luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Error message up to now was strictly for command line interactive use only. 

Improve error message when parsing .ac lines.
This commit is contained in:
Holger Vogt 2023-06-09 14:45:43 +02:00
parent d46cd894cc
commit c7ebb7aabb
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/spicelib/parser/inp2dot.c
View File

@ -182,6 +182,7 @@ dot_ac(char *line, CKTcircuit *ckt, INPtables *tab, struct card *current,
IFvalue *parm; /* a pointer to a value struct for function returns */ IFvalue *parm; /* a pointer to a value struct for function returns */
int which; /* which analysis we are performing */ int which; /* which analysis we are performing */
char *steptype; /* ac analysis, type of stepping function */ char *steptype; /* ac analysis, type of stepping function */
bool pdef = FALSE; /* issue a warning if default parameters are used */
NG_IGNORE(gnode); NG_IGNORE(gnode);
@ -193,15 +194,33 @@ dot_ac(char *line, CKTcircuit *ckt, INPtables *tab, struct card *current,
} }
IFC(newAnalysis, (ckt, which, "AC Analysis", &foo, task)); IFC(newAnalysis, (ckt, which, "AC Analysis", &foo, task));
INPgetTok(&line, &steptype, 1); /* get DEC, OCT, or LIN */ INPgetTok(&line, &steptype, 1); /* get DEC, OCT, or LIN */
if (!*steptype || (!ciprefix("dec", steptype) && !ciprefix("oct", steptype) && !ciprefix("lin", steptype))) {
current->error = "Missing DEC, OCT, or LIN\n";
return (0);
}
ptemp.iValue = 1; ptemp.iValue = 1;
GCA(INPapName, (ckt, which, foo, steptype, &ptemp)); GCA(INPapName, (ckt, which, foo, steptype, &ptemp));
tfree(steptype); tfree(steptype);
parm = INPgetValue(ckt, &line, IF_INTEGER, tab); /* number of points */ parm = INPgetValue(ckt, &line, IF_INTEGER, tab); /* number of points */
if (parm->iValue == 0)
pdef = TRUE;
GCA(INPapName, (ckt, which, foo, "numsteps", parm)); GCA(INPapName, (ckt, which, foo, "numsteps", parm));
if(!isdigit(*line))
pdef = TRUE;
parm = INPgetValue(ckt, &line, IF_REAL, tab); /* fstart */ parm = INPgetValue(ckt, &line, IF_REAL, tab); /* fstart */
GCA(INPapName, (ckt, which, foo, "start", parm)); GCA(INPapName, (ckt, which, foo, "start", parm));
parm = INPgetValue(ckt, &line, IF_REAL, tab); /* fstop */ parm = INPgetValue(ckt, &line, IF_REAL, tab); /* fstop */
if (parm->rValue == 0)
pdef = TRUE;
GCA(INPapName, (ckt, which, foo, "stop", parm)); GCA(INPapName, (ckt, which, foo, "stop", parm));
if (pdef) {
fprintf(stderr, "Warning, ngspice assumes default parameter(s) for ac simulation\n");
fprintf(stderr, " Check your ac or .ac line\n\n");
}
return (0); return (0);
} }