luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[PATCH #53] Removed useless zeroing of a copy of a variable (twice) when 

the original variable should be zeroed. Made cp_free_control static because
 it was only used in control.c and it was not defined in any header file.
 Added comments
This commit is contained in:
Jim Monte 2019-05-29 22:36:53 +02:00 committed by Holger Vogt
parent a4c3f7b608
commit c76bdee606
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/frontend/control.c
View File

@ -23,6 +23,8 @@ Author: 1985 Wayne A. Christopher, U. C. Berkeley CAD Group
#define BROKEN_STR "\002" #define BROKEN_STR "\002"
#define CONTINUED_STR "\003" #define CONTINUED_STR "\003"
static void cp_free_control(void); /* needed by resetcontrol */
/* Are we waiting for a command? This lets signal handling be /* Are we waiting for a command? This lets signal handling be
* more clever. */ * more clever. */
@ -108,8 +110,10 @@ pwlist_echo(wordlist *wlist, char *name) /*CDHW used to perform function of se
static void static void
ctl_free(struct control *ctrl) ctl_free(struct control *ctrl)
{ {
if (!ctrl) if (!ctrl) {
return; return;
}
wl_free(ctrl->co_cond); wl_free(ctrl->co_cond);
ctrl->co_cond = NULL; ctrl->co_cond = NULL;
tfree(ctrl->co_foreachvar); tfree(ctrl->co_foreachvar);
@ -122,8 +126,7 @@ ctl_free(struct control *ctrl)
ctrl->co_elseblock = NULL; ctrl->co_elseblock = NULL;
ctl_free(ctrl->co_next); ctl_free(ctrl->co_next);
ctrl->co_next = NULL; ctrl->co_next = NULL;
tfree(ctrl); txfree(ctrl);
ctrl = NULL;
} }
@ -875,7 +878,6 @@ cp_evloop(char *string)
/* This blows away the control structures... */ /* This blows away the control structures... */
void cp_free_control(void); /* needed by resetcontrol */
void cp_resetcontrol(void) void cp_resetcontrol(void)
{ {
fprintf(cp_err, "Warning: clearing control structures\n"); fprintf(cp_err, "Warning: clearing control structures\n");
@ -933,13 +935,15 @@ cp_toplevel(void)
/* va: This totally frees the control structures */ /* va: This totally frees the control structures */
void static void
cp_free_control(void) cp_free_control(void)
{ {
int i; int i;
for (i = stackp; i >= 0; i--) /* Free the control structures */
for (i = stackp; i >= 0; i--) {
ctl_free(control[i]); ctl_free(control[i]);
}
control[0] = cend[0] = NULL; control[0] = cend[0] = NULL;
stackp = 0; stackp = 0;