luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Allocating arrays of double* should use sizeof double* not double, even though they may be the same. Avoid potential divide by zero.

This commit is contained in:
Brian Taylor 2025-05-18 08:36:34 -07:00 committed by Holger Vogt
parent 4cf4b70c67
commit b516d0b4a9
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/maths/ni/nipzmeth.c
View File

@ -56,7 +56,7 @@ NIpzMuller(PZtrial **set, PZtrial *newtry)
} }
} }
magx = total / j; magx = (j != 0) ? (total / j) : total;
if (magx < min) if (magx < min)
magx = min; magx = min;

8
src/xspice/icm/analog/s_xfer/cfunc.mod
View File

@ -341,8 +341,8 @@ void cm_s_xfer(ARGS) /* structure holding parms, inputs, outputs, etc. */
/* Set den_coefficient & gain pointers to ITP values */ /* Set den_coefficient & gain pointers to ITP values */
/* for denominator coefficients & gain... */ /* for denominator coefficients & gain... */
old_den_coefficient = (double **) calloc((size_t) den_size, sizeof(double)); old_den_coefficient = (double **) calloc((size_t) den_size, sizeof(double *));
den_coefficient = (double **) calloc((size_t) den_size, sizeof(double)); den_coefficient = (double **) calloc((size_t) den_size, sizeof(double *));
for(i=den_size;i<2*den_size;i++){ for(i=den_size;i<2*den_size;i++){
old_den_coefficient[i-den_size] = (double *) cm_analog_get_ptr(i,1); old_den_coefficient[i-den_size] = (double *) cm_analog_get_ptr(i,1);
@ -350,8 +350,8 @@ void cm_s_xfer(ARGS) /* structure holding parms, inputs, outputs, etc. */
*(den_coefficient[i-den_size]) = *(old_den_coefficient[i-den_size]); *(den_coefficient[i-den_size]) = *(old_den_coefficient[i-den_size]);
} }
num_coefficient = (double **) calloc((size_t) num_size, sizeof(double)); num_coefficient = (double **) calloc((size_t) num_size, sizeof(double *));
old_num_coefficient = (double **) calloc((size_t) num_size, sizeof(double)); old_num_coefficient = (double **) calloc((size_t) num_size, sizeof(double *));
for(i=2*den_size;i<2*den_size+num_size;i++){ for(i=2*den_size;i<2*den_size+num_size;i++){
old_num_coefficient[i-2*den_size] = (double *) cm_analog_get_ptr(i,1); old_num_coefficient[i-2*den_size] = (double *) cm_analog_get_ptr(i,1);