luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ngspice crashes in eprvcd with 3 or more analog parameters. 

Fixed by changing the parameter sequence and zeroing the initial array.
This commit is contained in:
Paul Campbell 2026-04-24 15:28:49 +02:00 committed by Holger Vogt
parent 08accebcd3
commit 5490c3c33d
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/xspice/evt/evtprint.c
View File

@ -594,7 +594,7 @@ EVTprintvcd(wordlist *wl)
char *node_value[EPRINT_MAXARGS]; char *node_value[EPRINT_MAXARGS];
char *old_node_value[EPRINT_MAXARGS]; char *old_node_value[EPRINT_MAXARGS];
char node_ident[EPRINT_MAXARGS + 1]; char node_ident[EPRINT_MAXARGS + 1];
char vbuf[24][2][EPRINT_MAXARGS]; // Analog value strings char vbuf[EPRINT_MAXARGS][2][24]; // Analog value strings
CKTcircuit *ckt; CKTcircuit *ckt;
@ -607,6 +607,8 @@ EVTprintvcd(wordlist *wl)
char *value; char *value;
memset(vbuf, 0, sizeof(vbuf));
/* Check for the "-a" option (output analog values at timesteps) /* Check for the "-a" option (output analog values at timesteps)
* and "-t nn": specifies the VCD timestep with range 1fs to 1s */ * and "-t nn": specifies the VCD timestep with range 1fs to 1s */
@ -804,10 +806,10 @@ EVTprintvcd(wordlist *wl)
if (ctx.node_vector[i]) { if (ctx.node_vector[i]) {
/* Analog node or expression. */ /* Analog node or expression. */
sprintf(vbuf[0][i], "%.16g", get_real(i, 0.0, &ctx)); sprintf(vbuf[i][0], "%.16g", get_real(i, 0.0, &ctx));
node_value[i] = vbuf[0][i]; node_value[i] = vbuf[i][0];
old_node_value[i] = vbuf[1][i]; old_node_value[i] = vbuf[i][1];
strcpy(vbuf[1][i], vbuf[0][i]); strcpy(vbuf[i][1], vbuf[i][0]);
} else { } else {
/* This must return a pointer to a statically-allocated string. */ /* This must return a pointer to a statically-allocated string. */