luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

VIN 3 0 PULSE (-1 1 2NS 2NS 2NS 50 NS 100 NS) is now standard 

(missing dc value).
So revert the warning message:
VIN 3 0 dc 0 PULSE (-1 1 2NS 2NS 2NS 50 NS 100 NS) yields
a note message (not a warning)
This commit is contained in:
Holger Vogt 2022-05-19 12:04:44 +02:00
parent 0faf386d45
commit 4c8324f166
2 changed files with 21 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/spicelib/devices/isrc/isrctemp.c
View File

@ -35,17 +35,16 @@ ISRCtemp(GENmodel *inModel, CKTcircuit *ckt)
if(here->ISRCacGiven && !here->ISRCacPGiven) { if(here->ISRCacGiven && !here->ISRCacPGiven) {
here->ISRCacPhase = 0; here->ISRCacPhase = 0;
} }
if(!here->ISRCdcGiven) { if (!here->ISRCdcGiven && !here->ISRCfuncTGiven) {
/* no DC value - either have a transient value, or none */ /* no DC value, no transient value */
if(here->ISRCfuncTGiven) { SPfrontEnd->IFerrorf(ERR_INFO,
SPfrontEnd->IFerrorf (ERR_WARNING,
"%s: no DC value, transient time 0 value used",
here->ISRCname);
} else {
SPfrontEnd->IFerrorf (ERR_WARNING,
"%s: has no value, DC 0 assumed", "%s: has no value, DC 0 assumed",
here->ISRCname); here->ISRCname);
} }
else if (here->ISRCdcGiven && here->ISRCfuncTGiven) {
SPfrontEnd->IFerrorf(ERR_INFO,
"%s: dc value used for op instead of transient time 0 value.",
here->ISRCname);
} }
if(!here->ISRCmGiven) if(!here->ISRCmGiven)
here->ISRCmValue = 1; here->ISRCmValue = 1;

16
src/spicelib/devices/vsrc/vsrctemp.c
View File

@ -41,17 +41,17 @@ VSRCtemp(GENmodel *inModel, CKTcircuit *ckt)
if(here->VSRCacGiven && !here->VSRCacPGiven) { if(here->VSRCacGiven && !here->VSRCacPGiven) {
here->VSRCacPhase = 0; here->VSRCacPhase = 0;
} }
if(!here->VSRCdcGiven) { if (!here->VSRCdcGiven && !here->VSRCfuncTGiven) {
/* no DC value - either have a transient value, or none */ /* no DC value, no transient value */
if(here->VSRCfuncTGiven) { SPfrontEnd->IFerrorf(ERR_INFO,
SPfrontEnd->IFerrorf (ERR_WARNING,
"%s: no DC value, transient time 0 value used",
here->VSRCname);
} else {
SPfrontEnd->IFerrorf (ERR_WARNING,
"%s: has no value, DC 0 assumed", "%s: has no value, DC 0 assumed",
here->VSRCname); here->VSRCname);
} }
else if (here->VSRCdcGiven && here->VSRCfuncTGiven) {
/* no DC value, no transient value */
SPfrontEnd->IFerrorf(ERR_INFO,
"%s: dc value used for op instead of transient time 0 value.",
here->VSRCname);
} }
radians = here->VSRCacPhase * M_PI / 180.0; radians = here->VSRCacPhase * M_PI / 180.0;
here->VSRCacReal = here->VSRCacMag * cos(radians); here->VSRCacReal = here->VSRCacMag * cos(radians);