luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

function deriv: This is just a preliminary fix: prevent a crash 

when base > 0.

But when is base supposed to be > 0 ? More invetigation is needed.
This commit is contained in:
Holger Vogt 2022-04-06 10:13:52 +02:00
parent 321d53a4e9
commit 26c50de68b
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/maths/cmaths/cmath4.c
View File

@ -366,12 +366,6 @@ cx_deriv(void *data, short int type, int length, int *newlength, short int *newt
* check that the frequency is complex vector not to abort. * check that the frequency is complex vector not to abort.
*/ */
/* Original problematic code
* for (i = 0; i < length; i++)
* scale[i] = pl->pl_scale->v_realdata[i];
*/
/* Modified to deal with complex frequency vector */ /* Modified to deal with complex frequency vector */
if (iscomplex(pl->pl_scale)) if (iscomplex(pl->pl_scale))
for (i = 0; i < length; i++) for (i = 0; i < length; i++)
@ -412,16 +406,15 @@ cx_deriv(void *data, short int type, int length, int *newlength, short int *newt
k = j; k = j;
} }
/* FIXME: replaced j+base by j, to avoid crash, but why j+base here? */
for (j = k; j < length; j++) for (j = k; j < length; j++)
{ {
/* Again the same error */
/* x = pl->pl_scale->v_realdata[j + base]; */
if (iscomplex(pl->pl_scale)) if (iscomplex(pl->pl_scale))
x = realpart(pl->pl_scale->v_compdata[j+base]); /* For complex scale vector */ x = realpart(pl->pl_scale->v_compdata[j]); /* For complex scale vector */
else else
x = pl->pl_scale->v_realdata[j + base]; /* For real scale vector */ x = pl->pl_scale->v_realdata[j]; /* For real scale vector */
outdata[j + base] = ft_peval(x, coefs, degree - 1); outdata[j] = ft_peval(x, coefs, degree - 1);
} }
} }