luke
/
ngspice
mirror of https://git.code.sf.net/p/ngspice/ngspice
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ziwschenstand, checked code for maths errors

This commit is contained in:
Markus Mueller 2020-05-17 20:20:00 +02:00
parent 418966c6e5
commit 03750cd24e
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/spicelib/devices/hicum2/hicumL2.cpp
View File

@ -2398,8 +2398,6 @@ HICUMload(GENmodel *inModel, CKTcircuit *ckt)
Ibpbi_Vbiei = -Vbpbi * rbi_Vbiei / (rbi*rbi); Ibpbi_Vbiei = -Vbpbi * rbi_Vbiei / (rbi*rbi);
Ibpbi_Vbici = -Vbpbi * rbi_Vbici / (rbi*rbi); Ibpbi_Vbici = -Vbpbi * rbi_Vbici / (rbi*rbi);
Qjcx_i_Vbci = Cjcx_i; Qjcx_i_Vbci = Cjcx_i;
Qjcx_ii_Vbpci = Cjcx_ii; Qjcx_ii_Vbpci = Cjcx_ii;
Qjep_Vbpei = Cjep; Qjep_Vbpei = Cjep;
@ -2728,7 +2726,7 @@ HICUMload(GENmodel *inModel, CKTcircuit *ckt)
} }
} }
// Write DC Currents and thei derivatives on the correct variables of the HiCUM equivalent circuit // Write DC Currents and their derivatives on the correct variables of the HiCUM equivalent circuit
*(ckt->CKTstate0 + here->HICUMvbiei) = Vbiei; *(ckt->CKTstate0 + here->HICUMvbiei) = Vbiei;
*(ckt->CKTstate0 + here->HICUMvbici) = Vbici; *(ckt->CKTstate0 + here->HICUMvbici) = Vbici;

11
src/spicelib/devices/hicum2/overview_files.md
View File

@ -66,3 +66,14 @@ See test case in DMT where this is compared against ADS.
# useful stuff # useful stuff
- non-ancient explanation how equation system of spice looks: - non-ancient explanation how equation system of spice looks:
https://spicesharp.github.io/SpiceSharp/articles/custom_components/modified_nodal_analysis.html#nonlinear-components https://spicesharp.github.io/SpiceSharp/articles/custom_components/modified_nodal_analysis.html#nonlinear-components
# Checking Stamps of Elements without Self-Heating
- General quesiton: rhs has opposite sign than expected?
- ijbei -> ok
- ijbep -> ok
- ijbci -> ok
- it -> ok
- rcx -> ok
- rbx -> ok
- re -> ok
- rbi -> ok (Great work diemtar!)