e88dcba1c5
Guided by CodeQL static code analyser. FileMayNotBeClosed.ql FileMayNeverBeClosed.ql The trick with "if(fp != stdout)" is problematic (to analyser) as technically 'stdout' can be a global pointer that COULD be modified any time, so it might have changed between the fopen() and fclose() calls so the close MAY NEVER occurs (which is problem the analyzer can see). So local state is maintained as a bool which will also clarify to the compiler see the intention without concern for external stdout modification. Some items appear to be out and out leaks when certain commands are use. |
||
|---|---|---|
| .. | ||
| CmdAB.c | ||
| CmdAuto.c | ||
| CmdCD.c | ||
| CmdE.c | ||
| CmdFI.c | ||
| CmdLQ.c | ||
| CmdRS.c | ||
| CmdSubrs.c | ||
| CmdTZ.c | ||
| CmdWizard.c | ||
| Makefile | ||
| commands.h | ||