mirror of
https://github.com/RTimothyEdwards/magic.git
synced 2026-09-01 02:28:41 +02:00
Darryl L. MilesandClaude Opus 4.8
b3d6540f13
MAGIC_VERSION / MAGIC_REVISION / MAGIC_COMMIT / MAGIC_BUILDDATE were on the
global DFLAGS, so every object's compile command line carried them. Because
the command line is part of ccache/sccache's hash key and MAGIC_BUILDDATE
changes every second, that meant a cache miss on every unit on every build;
it also smeared the baked-in date/commit across "whenever each file last
recompiled".
Move the four values into a single translation unit:
* utils/magic_buildinfo.h -- extern MagicVersion/MagicRevision/MagicCommit/
MagicCompileTime (MagicCommit is new; the other three moved here from
utils/magic.h, which now includes this header).
* utils/buildinfo.c -- the ONLY unit compiled with the version defines
(target-specific `buildinfo.o: DFLAGS += ${DFLAGS_MAGICVERSION}` in
utils/Makefile.in); it defines the four globals. ${DFLAGS_MAGICVERSION}
is removed from the global DFLAGS/DFLAGS_NOSTUB.
Consumers updated to read the runtime symbol instead of the compile-time
macro:
* magicTop.c / tclmagic.c no longer define the globals (the MAGIC_WRAPPER
duplicate-symbol guard is gone -- buildinfo.o owns them for every variant,
including WASM, which links both mains).
* Tcl_PkgProvide/PkgRequire in router/ext2spice/lef/ext2sim/plot/tclmagic
now pass MagicVersion.
* extflat: EFVersion (a static-initialized copy of MAGIC_VERSION) is dropped;
EFread.c compares the .ext version against MagicVersion directly -- the same
value ExtCell.c already *writes* into .ext files, so read and write are now
consistent.
Verified: only buildinfo.o carries -DMAGIC_* (hash/DBio/windCmdSZ carry none);
Tcl (375 files) and --without-tcl builds rc=0, version/commit/date embedded in
tclmagic.so, magicTop.o no longer defines MagicVersion; in-tree source clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
75 lines
1.9 KiB
C
75 lines
1.9 KiB
C
/*--------------------------------------------------------------*/
|
|
/* tclplot.c */
|
|
/* */
|
|
/* Allows the "plot" feature to be loaded as a module */
|
|
/* under the Tcl/Tk version of magic. Loading is */
|
|
/* automatic upon invoking the "plot" command. */
|
|
/*--------------------------------------------------------------*/
|
|
|
|
#ifdef PLOT_AUTO
|
|
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
|
|
#include "tcltk/tclmagic.h"
|
|
#include "utils/magic.h"
|
|
#include "utils/geometry.h"
|
|
#include "tiles/tile.h"
|
|
#include "utils/hash.h"
|
|
#include "database/database.h"
|
|
#include "windows/windows.h"
|
|
#include "commands/commands.h"
|
|
#include "utils/tech.h"
|
|
#include "plot/plot.h"
|
|
#include "dbwind/dbwind.h"
|
|
|
|
/* External routines */
|
|
|
|
extern void CmdPlot();
|
|
|
|
/*
|
|
* ----------------------------------------------------------------------------
|
|
*
|
|
* Tcl package initialization function
|
|
*
|
|
* ----------------------------------------------------------------------------
|
|
*/
|
|
|
|
int
|
|
Tclplot_Init(interp)
|
|
Tcl_Interp *interp;
|
|
{
|
|
int n;
|
|
SectionID invplot;
|
|
|
|
/* Sanity checks! */
|
|
if (interp == NULL) return TCL_ERROR;
|
|
if (Tcl_PkgRequire(interp, "Tclmagic", MagicVersion, 0) == NULL)
|
|
return TCL_ERROR;
|
|
if (Tcl_InitStubs(interp, Tclmagic_InitStubsVersion, 0) == NULL) return TCL_ERROR;
|
|
|
|
TxPrintf("Auto-loading PLOT module\n");
|
|
TxFlushOut();
|
|
|
|
/* Replace the auto-load function with the ones defined in */
|
|
/* this package in the command functions list. */
|
|
|
|
if (WindReplaceCommand(DBWclientID, "plot", CmdPlot) < 0)
|
|
return TCL_ERROR;
|
|
|
|
/* Now we need to do TechAddClient and reload the tech file */
|
|
|
|
TechAddClient("plot", PlotTechInit, PlotTechLine, PlotTechFinal,
|
|
(SectionID) 0, (SectionID *) 0, FALSE);
|
|
|
|
/* No initialization function to go here */
|
|
|
|
invplot = TechSectionGetMask("plot", NULL);
|
|
if (!TechLoad(NULL, invplot)) return TCL_ERROR;
|
|
|
|
Tcl_PkgProvide(interp, "Plot", MagicVersion);
|
|
return TCL_OK;
|
|
}
|
|
|
|
#endif /* PLOT_AUTO */
|