luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,381 Commits 6 Branches 703 Tags 32 MiB
Commit Graph

18 Commits

Author SHA1 Message Date
Darryl L. Miles b1424bfaf3 plow: add ANSI prototypes plowMergeBottom() plowMergeTop() 
This exposes the incorrect call sites, that are also fixed here.
 2025-10-04 20:50:31 -04:00
Darryl L. Miles e88dcba1c5 CodeQL File{MayNot,Never}BeClosed.ql file-handle resource leaks 
Guided by CodeQL static code analyser.

FileMayNotBeClosed.ql
FileMayNeverBeClosed.ql

The trick with "if(fp != stdout)" is problematic (to analyser) as
technically 'stdout' can be a global pointer that COULD be modified any
time, so it might have changed between the fopen() and fclose() calls so
the close MAY NEVER occurs (which is problem the analyzer can see).

So local state is maintained as a bool which will also clarify to the
compiler see the intention without concern for external stdout
modification.

Some items appear to be out and out leaks when certain commands are use.
 2025-02-22 21:02:49 -05:00
Darryl L. Miles 554327f1d3 plowSrShadowXxx() callback plowShowShadow() correct return type 
was void, now int.
 2025-02-22 20:58:59 -05:00
Darryl L. Miles 86bb97948f plowSrShadowBack() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles cfd71f1b5d plowSrShadow() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles d149c83a8a plowSrOutline() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles cf0f9311ab plowFindWidthBack() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles 2ff6d6113d plowFindWidth() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles bc5a4a0fb1 Plow() pass by-pointer const TileTypeBitMask* instead of by-value 
sizeof(TileTypeBitMask) == 32
 2025-02-22 20:58:59 -05:00
Darryl L. Miles 6afadf9809 gcc11 -Wall -Wpedantic cleanup (post __attribute__) 2025-01-06 16:25:38 +00:00
Darryl L. Miles 14b6453707 LookupStruct() constify call-site 
irouter/irTestCmd.c: LookupStruct() constify call-site
irouter/irCommand.c: LookupStruct() constify call-site
mzrouter/mzTestCmd.c: LookupStruct() constify call-site
mzrouter/mzTech.c: LookupStruct() constify call-site
router/rtrCmd.c: LookupStruct() constify call-site
plow/PlowTest.c: LookupStruct() constify call-site
plow/PlowTech.c: LookupStruct() constify call-site
plot/plotVers.c: LookupStruct() constify call-site
grouter/grouteTest.c: LookupStruct() constify call-site
garouter/gaTest.c: LookupStruct() constify call-site
extract/ExtTest.c: LookupStruct() constify call-site
extract/ExtTech.c: LookupStruct() constify call-site
extflat/EFread.c: LookupStruct() constify call-site
DRCtech.c: LookupStruct() constify call-site
debugFlags.c: LookupStruct() constify call-site
CmdSubrs.c: LookupStruct() constify call-site
geometry.c: LookupStruct() constify call-site
set.c: LookupStruct() constify call-site
 2024-12-26 15:20:58 -05:00
Darryl L. Miles b654647fdc PlowTest.c: warning: enumeration value 'PC_ERROR' not handled in switch 
False positive.

Added no-op case statement, but code above looks the case should never
execute due return from function.

GCC14 -Wall cleanup series [-Wswitch]
 2024-10-09 21:12:55 -04:00
Darryl L. Miles 967b41343b GCC14: warning: missing braces around initializer 
GCC14 -Wall cleanup series [-Wmissing-braces]
 2024-10-09 21:12:55 -04:00
Darryl Miles 6946ea6845 plow/PlowTest.c: Wrong type of arguments to formatting function 
Fix code scanning alert no. 106: Wrong type of arguments to formatting function (#30)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
 2024-10-01 12:36:12 -04:00
Darryl Miles 384e59ea98 plow/PlowTest.c: Wrong type of arguments to formatting function 
Fix code scanning alert no. 104: Wrong type of arguments to formatting function (#29)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
 2024-10-01 12:36:12 -04:00
Darryl Miles 318993cb7b plow/PlowTest.c: Wrong type of arguments to formatting function 
Fix code scanning alert no. 103: Wrong type of arguments to formatting function (#28)

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
 2024-10-01 12:36:12 -04:00
Tim Edwards 2af38a4191 Updates from running the fix-ending-whitespace script. 2020-05-23 17:13:14 -04:00
Tim Edwards 231a299b16 Initial commit at Tue Apr 25 08:41:48 EDT 2017 by tim on stravinsky 2017-04-25 08:41:48 -04:00