luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grTCairo1.c: GrTCairoIconUpdate() potential -1 out-of-bound access 

SonarCloud
Access of 'char' element in the region at index -1
This was not picked up, even though similar code was.
This commit is contained in:
Darryl L. Miles 2024-10-16 10:20:09 +01:00 committed by Tim Edwards
parent ee9d4df081
commit ef7f989da6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
graphics/grTCairo1.c
View File

@ -1490,7 +1490,7 @@ char *text;
XSetClassHint( grXdpy, wind, &class); XSetClassHint( grXdpy, wind, &class);
if (text) if (text)
{ {
if ((brack = strchr(text, '['))) if ((brack = strchr(text, '[')) && brack != text)
{ {
brack--; brack--;
*brack = 0; *brack = 0;