luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

calma/CalmaWrite.c: calmaProcessBoundary() Dereference of null pointer 

Theoretical NULL pointer deref.  Seems like false positive as a
BOUNDARY record does not make sense with no points.

This guards against a potential crash from a bad data model.

SonarCloud
Dereference of null pointer
https://sonarcloud.io/project/issues?open=AZJB17hXNGfDNup0Rktk&id=dlmiles_magic
This commit is contained in:
Darryl L. Miles 2024-10-04 20:07:03 +01:00 committed by Tim Edwards
parent a3a40bee73
commit dd6bb9baf4
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
calma/CalmaWrite.c
View File

@ -2407,8 +2407,11 @@ calmaProcessBoundary(
calmaOutI4(lbref->lb_start.p_y * calmaPaintScale, f); calmaOutI4(lbref->lb_start.p_y * calmaPaintScale, f);
chkcount++; chkcount++;
} }
calmaOutI4(listtop->lb_start.p_x * calmaPaintScale, f); if (listtop != NULL)
calmaOutI4(listtop->lb_start.p_y * calmaPaintScale, f); {
calmaOutI4(listtop->lb_start.p_x * calmaPaintScale, f);
calmaOutI4(listtop->lb_start.p_y * calmaPaintScale, f);
}
if (chkcount != bounds->bt_points) if (chkcount != bounds->bt_points)
TxError("Points recorded=%d; Points written=%d\n", TxError("Points recorded=%d; Points written=%d\n",