luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ext2spice/ext2spice.c: EFDone() Call to function with fewer arguments than declared parameters 

Passing NULL is valid in efFreeNodeList() to not perform callback..

extflat/EFdef.c:
^231a299 (2017-04-25 08:41:48 -0400  97) void
5e3c26c9 (2021-12-13 18:05:53 -0500  98) EFDone(func)
5e3c26c9 (2021-12-13 18:05:53 -0500  99)     int (*func)();

commit 5e3c26c95a (tag: 8.3.241)
Date:   Mon Dec 13 18:05:53 2021 -0500

extflat/EFdef.c:97
void EFDone(int (*func)());

extflat/EFbuild.c:2180
void efFreeNodeList(EFNode *head, int (*func)());

CodeQL: https://github.com/dlmiles/magic/security/code-scanning/20
        https://github.com/dlmiles/magic/security/code-scanning/21
        https://github.com/dlmiles/magic/security/code-scanning/22
This commit is contained in:
Darryl L. Miles 2024-09-29 23:00:00 +01:00 committed by Tim Edwards
parent d2ae7f78e8
commit c8e00ef494
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ext2spice/ext2spice.c
View File

@ -840,7 +840,7 @@ runexttospice:
inName = EFArgs(argc, argv, &err_result, spcParseArgs, (ClientData) NULL); inName = EFArgs(argc, argv, &err_result, spcParseArgs, (ClientData) NULL);
if (err_result == TRUE) if (err_result == TRUE)
{ {
EFDone(); EFDone(NULL);
return; return;
} }
@ -878,7 +878,7 @@ runexttospice:
if (EFReadFile(inName, esDoHierarchy, esDoExtResis, FALSE, TRUE) if (EFReadFile(inName, esDoHierarchy, esDoExtResis, FALSE, TRUE)
== FALSE) == FALSE)
{ {
EFDone(); EFDone(NULL);
return; return;
} }
@ -894,7 +894,7 @@ runexttospice:
#else #else
TxError("exttospice: Unable to open file %s for writing\n", spcesOutName); TxError("exttospice: Unable to open file %s for writing\n", spcesOutName);
#endif #endif
EFDone(); EFDone(NULL);
return; return;
} }