luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tcl/tk: Fix layer toolbar icon synchronization on left-click 

There is a bug where left-clicking a hidden layer in the toolbar successfully makes the layer visible in the layout but fails to update the toolbar icon to the "active" state.

The root cause is a positional argument mismatch in magic::toolupdate. When the Magic C-core issues a callback for a "see" command with two arguments, the third argument (layerlist) is passed as an empty string ("") rather than being omitted. This prevents the Tcl procedure from falling back to its hardcoded default of "none", causing the script to skip the logic that reassigns $yesno to "yes".

This patch changes the default value of $layerlist to "" and updates the conditional check to ensure the state and layer name are correctly reassigned regardless of how the C-core signals the update.
This commit is contained in:
Ahmed Nematallah 2026-05-02 18:09:18 +02:00 committed by R. Timothy Edwards
parent 900f6d7b0f
commit c3ee33e9a1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tcltk/wrapper.tcl
View File

@ -706,7 +706,7 @@ proc magic::cursorview {win} {
*bypass logcommands resume
}
proc magic::toolupdate {win {yesno "yes"} {layerlist "none"}} {
proc magic::toolupdate {win {yesno "yes"} {layerlist ""}} {
global Winopts
if {[magic::display] == "NULL"} {return}
@ -728,7 +728,7 @@ proc magic::toolupdate {win {yesno "yes"} {layerlist "none"}} {
# Don't do anything if toolbar is not present
if { $Winopts(${topname},toolbar) == 0 } { return }
if {$layerlist == "none"} {
if {$layerlist == ""} {
set layerlist $yesno
set yesno "yes"
}