luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

22 x warning: suggest parentheses around assignment used as truth value 

lefTech.c:107:16: warning: suggest parentheses around assignment used as truth value
lefTech.c:160:16: warning: suggest parentheses around assignment used as truth value
lefTech.c:426:16: warning: suggest parentheses around assignment used as truth value
lefTech.c:453:16: warning: suggest parentheses around assignment used as truth value
lefTech.c:486:16: warning: suggest parentheses around assignment used as truth value
lefWrite.c:190:9: warning: suggest parentheses around assignment used as truth value
lefWrite.c:303:12: warning: suggest parentheses around assignment used as truth value
lefWrite.c:315:12: warning: suggest parentheses around assignment used as truth value
lefWrite.c:377:16: warning: suggest parentheses around assignment used as truth value
lefWrite.c:439:16: warning: suggest parentheses around assignment used as truth value
lefWrite.c:1222:12: warning: suggest parentheses around assignment used as truth value
lefWrite.c:2246:12: warning: suggest parentheses around assignment used as truth value
defWrite.c:415:12: warning: suggest parentheses around assignment used as truth value
defWrite.c:447:12: warning: suggest parentheses around assignment used as truth value
defWrite.c:2039:16: warning: suggest parentheses around assignment used as truth value
defWrite.c:2104:16: warning: suggest parentheses around assignment used as truth value
defWrite.c:2478:16: warning: suggest parentheses around assignment used as truth value
defWrite.c:2498:20: warning: suggest parentheses around assignment used as truth value
defWrite.c:3066:16: warning: suggest parentheses around assignment used as truth value
defWrite.c:3084:28: warning: suggest parentheses around assignment used as truth value
defWrite.c:3111:28: warning: suggest parentheses around assignment used as truth value
lefRead.c:651:12: warning: suggest parentheses around assignment used as truth value

GCC14 -Wall cleanup series [-Wparentheses]
This commit is contained in:
Darryl L. Miles 2024-10-04 17:23:02 +01:00 committed by Tim Edwards
parent 76d8c8c911
commit a6e1596ba6
4 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lef/defWrite.c
View File

@ -412,7 +412,7 @@ defHNsprintf(str, hierName, divchar)
/* (which are interpreted as wildcard characters by LEF/DEF). */ /* (which are interpreted as wildcard characters by LEF/DEF). */
cp = hierName->hn_name; cp = hierName->hn_name;
while (c = *cp++) while ((c = *cp++))
{ {
switch (c) switch (c)
{ {
@ -444,7 +444,7 @@ char *defHNsprintfPrefix(hierName, str, divchar)
str = defHNsprintfPrefix(hierName->hn_parent, str, divchar); str = defHNsprintfPrefix(hierName->hn_parent, str, divchar);
cp = hierName->hn_name; cp = hierName->hn_name;
while (*str++ = *cp++) ; while ((*str++ = *cp++)) ;
*(--str) = divchar; *(--str) = divchar;
return ++str; return ++str;
} }
@ -2036,7 +2036,7 @@ defGetType(ttype, lefptr, do_vias)
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (lefl && (do_vias == FALSE) && (contact == CLASS_VIA) && if (lefl && (do_vias == FALSE) && (contact == CLASS_VIA) &&
@ -2101,7 +2101,7 @@ defWriteVias(f, rootDef, oscale, lefMagicToLefLayer)
cscale = CIFGetOutputScale(1); cscale = CIFGetOutputScale(1);
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
int size, sep, border; int size, sep, border;
char *us1, *us2; char *us1, *us2;
@ -2475,7 +2475,7 @@ defWriteBlockages(f, rootDef, oscale, MagicToLefTable)
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (lefl != NULL) if (lefl != NULL)
@ -2495,7 +2495,7 @@ defWriteBlockages(f, rootDef, oscale, MagicToLefTable)
{ {
numblocks = 0; numblocks = 0;
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if ((lefl != NULL) && ((lefl->lefClass == CLASS_ROUTE) || if ((lefl != NULL) && ((lefl->lefClass == CLASS_ROUTE) ||
@ -3063,7 +3063,7 @@ DefWriteCell(def, outName, allSpecial, units, analRetentive)
fprintf(f, "NONDEFAULTRULES %d ;\n", numrules); fprintf(f, "NONDEFAULTRULES %d ;\n", numrules);
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefNonDefaultRules, &hs)) while ((he = HashNext(&LefNonDefaultRules, &hs)))
{ {
nrules = (LefRules *)HashGetValue(he); nrules = (LefRules *)HashGetValue(he);
fprintf(f, " - %s", nrules->name); fprintf(f, " - %s", nrules->name);
@ -3081,7 +3081,7 @@ DefWriteCell(def, outName, allSpecial, units, analRetentive)
lefLayer *lefl2; lefLayer *lefl2;
HashStartSearch(&hs2); HashStartSearch(&hs2);
while (he2 = HashNext(&LefInfo, &hs2)) while ((he2 = HashNext(&LefInfo, &hs2)))
{ {
lefl2 = (lefLayer *)HashGetValue(he2); lefl2 = (lefLayer *)HashGetValue(he2);
if (lefl2->lefClass == CLASS_ROUTE) if (lefl2->lefClass == CLASS_ROUTE)
@ -3108,7 +3108,7 @@ DefWriteCell(def, outName, allSpecial, units, analRetentive)
/* Put the reference counts back to the way they were */ /* Put the reference counts back to the way they were */
HashStartSearch(&hs2); HashStartSearch(&hs2);
while (he2 = HashNext(&LefInfo, &hs2)) while ((he2 = HashNext(&LefInfo, &hs2)))
{ {
lefl2 = (lefLayer *)HashGetValue(he2); lefl2 = (lefLayer *)HashGetValue(he2);
if (lefl2->refCnt < 0) if (lefl2->refCnt < 0)

2
lef/lefRead.c
View File

@ -648,7 +648,7 @@ LefRedefined(lefl, redefname)
records = 0; records = 0;
altName = NULL; altName = NULL;
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
slef = (lefLayer *)HashGetValue(he); slef = (lefLayer *)HashGetValue(he);
if (slef == lefl) if (slef == lefl)

10
lef/lefTech.c
View File

@ -104,7 +104,7 @@ LefTechInit()
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;
@ -157,7 +157,7 @@ lefRemoveGeneratedVias()
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;
@ -423,7 +423,7 @@ LefTechScale(scalen, scaled)
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;
@ -450,7 +450,7 @@ LefTechScale(scalen, scaled)
/* Return all refCnt values to normal */ /* Return all refCnt values to normal */
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;
@ -483,7 +483,7 @@ LefTechSetDefaults()
if (LefInfo.ht_table != (HashEntry **) NULL) if (LefInfo.ht_table != (HashEntry **) NULL)
{ {
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;

14
lef/lefWrite.c
View File

@ -187,7 +187,7 @@ lefFileOpen(def, file, suffix, mode, prealfile)
else else
ends++; ends++;
if (endp = strrchr(ends, '.')) if ((endp = strrchr(ends, '.')))
{ {
if (strcmp(endp, suffix)) if (strcmp(endp, suffix))
{ {
@ -300,7 +300,7 @@ lefWriteHeader(def, f, lefTech, propTable, siteTable)
HashStartSearch(&hs); HashStartSearch(&hs);
nprops = 0; nprops = 0;
while (he = HashNext(propTable, &hs)) while ((he = HashNext(propTable, &hs)))
{ {
if (nprops == 0) fprintf(f, "PROPERTYDEFINITIONS\n"); if (nprops == 0) fprintf(f, "PROPERTYDEFINITIONS\n");
nprops++; nprops++;
@ -312,7 +312,7 @@ lefWriteHeader(def, f, lefTech, propTable, siteTable)
if (nprops > 0) fprintf(f, "END PROPERTYDEFINITIONS\n\n"); if (nprops > 0) fprintf(f, "END PROPERTYDEFINITIONS\n\n");
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(siteTable, &hs)) while ((he = HashNext(siteTable, &hs)))
{ {
/* Output the SITE as a macro */ /* Output the SITE as a macro */
CellDef *siteDef; CellDef *siteDef;
@ -374,7 +374,7 @@ lefWriteHeader(def, f, lefTech, propTable, siteTable)
float oscale = CIFGetOutputScale(1000); /* lambda->micron conversion */ float oscale = CIFGetOutputScale(1000); /* lambda->micron conversion */
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (!lefl) continue; if (!lefl) continue;
@ -436,7 +436,7 @@ lefWriteHeader(def, f, lefTech, propTable, siteTable)
/* Return reference counts to normal */ /* Return reference counts to normal */
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefl = (lefLayer *)HashGetValue(he); lefl = (lefLayer *)HashGetValue(he);
if (lefl && lefl->refCnt < 0) if (lefl && lefl->refCnt < 0)
@ -1219,7 +1219,7 @@ lefWriteMacro(def, f, scale, setback, pinonly, toplayer, domaster)
TTMaskSetType(&lc.rmask, lab->lab_type); TTMaskSetType(&lc.rmask, lab->lab_type);
HashStartSearch(&hs); HashStartSearch(&hs);
while (he = HashNext(&LefInfo, &hs)) while ((he = HashNext(&LefInfo, &hs)))
{ {
lefLayer *lefl = (lefLayer *)HashGetValue(he); lefLayer *lefl = (lefLayer *)HashGetValue(he);
if (lefl && (lefl->lefClass == CLASS_ROUTE || lefl->lefClass == CLASS_VIA if (lefl && (lefl->lefClass == CLASS_ROUTE || lefl->lefClass == CLASS_VIA
@ -2247,7 +2247,7 @@ LefWriteAll(rootUse, writeTopCell, lefTech, lefHide, lefPinOnly, lefTopLayer,
HashKill(&propHashTbl); HashKill(&propHashTbl);
HashKill(&siteHashTbl); HashKill(&siteHashTbl);
while (def = (CellDef *) StackPop(lefDefStack)) while ((def = (CellDef *) StackPop(lefDefStack)))
{ {
def->cd_client = (ClientData) 0; def->cd_client = (ClientData) 0;
if (!SigInterruptPending) if (!SigInterruptPending)