luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CodeQL FileMayNotBeClosed.ql PaCheckCompressed() apparently leaks an 'fd' 

CodeQL complains of a _potential_ leak (I can't see it), seems false
positive but also a clear case to use POSIX access(R_OK) instead.
This commit is contained in:
Darryl L. Miles 2025-02-13 08:22:43 +00:00 committed by Tim Edwards
parent e88dcba1c5
commit a60259ab63
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
utils/path.c
View File

@ -82,19 +82,14 @@ char *
PaCheckCompressed(filename) PaCheckCompressed(filename)
const char *filename; const char *filename;
{ {
int fd;
char *gzname; char *gzname;
gzname = (char *)mallocMagic(strlen(filename) + 4); gzname = (char *)mallocMagic(strlen(filename) + 4);
sprintf(gzname, "%s.gz", filename); sprintf(gzname, "%s.gz", filename);
fd = open(gzname, O_RDONLY); int err = access(gzname, R_OK);
if (fd < 0) if (err < 0)
{
strcpy(gzname, filename); /* always shorter than allocation */ strcpy(gzname, filename); /* always shorter than allocation */
}
else
close(fd);
return gzname; return gzname;
} }