luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gcr/gcrDebug.c Opened stream never closed. Potential resource leak 

A false positive in practice, made clearer by using a 2nd variable
with attention drawing name.

SonarCloud
gcr/gcrDebug.c:429 Opened stream never closed. Potential resource leak
https://sonarcloud.io/project/issues?open=AZJB17OzNGfDNup0Rj-t&id=dlmiles_magic
This commit is contained in:
Darryl L. Miles 2024-09-29 23:00:00 +01:00 committed by Tim Edwards
parent 0cea17e801
commit 8b2efd5d7d
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
gcr/gcrDebug.c
View File

@ -373,14 +373,13 @@ gcrPrDensity(ch, chanDensity)
{
int i, diff;
char name[256];
FILE *fp;
FILE *fp, *fp_always_close;
(void) sprintf(name, "dens.%d.%d.%d.%d",
ch->gcr_area.r_xbot, ch->gcr_area.r_ybot,
ch->gcr_area.r_xtop, ch->gcr_area.r_ytop);
fp = fopen(name, "w");
if (fp == NULL)
fp = stdout;
fp_always_close = fopen(name, "w");
fp = fp_always_close ? fp_always_close : stdout;
fprintf(fp, "Chan width: %d\n", ch->gcr_width);
fprintf(fp, "Chan length: %d\n", ch->gcr_length);
@ -424,8 +423,8 @@ gcrPrDensity(ch, chanDensity)
}
(void) fflush(fp);
if (fp != stdout)
(void) fclose(fp);
if (fp_always_close != NULL)
(void) fclose(fp_always_close);
}
/*