luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grTk1.c: GrTkIconUpdate() potential -1 out-of-bound access 

SonarCloud
Access of 'char' element in the region at index -1
This was not picked up, even though similar code was.
This commit is contained in:
Darryl L. Miles 2024-10-16 10:20:51 +01:00 committed by Tim Edwards
parent ef7f989da6
commit 89fa935416
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
graphics/grTk1.c
View File

@ -1754,7 +1754,9 @@ GrTkIconUpdate(w, text) /* See Blt code */
class.res_class = "magic"; class.res_class = "magic";
XSetClassHint( grXdpy, wind, &class); XSetClassHint( grXdpy, wind, &class);
if ((brack = strchr(text,'['))) if (text == NULL)
return;
if ((brack = strchr(text,'[')) && brack != text)
{ {
brack--; brack--;
*brack = 0; *brack = 0;