grTk1.c: GrTkIconUpdate() potential -1 out-of-bound access

SonarCloud
Access of 'char' element in the region at index -1
This was not picked up, even though similar code was.
This commit is contained in:
Darryl L. Miles
2024-12-26 13:01:24 -05:00
committed by Tim Edwards
parent ef7f989da6
commit 89fa935416
+3 -1
View File
@@ -1754,7 +1754,9 @@ GrTkIconUpdate(w, text) /* See Blt code */
class.res_class = "magic";
XSetClassHint( grXdpy, wind, &class);
if ((brack = strchr(text,'[')))
if (text == NULL)
return;
if ((brack = strchr(text,'[')) && brack != text)
{
brack--;
*brack = 0;