luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Corrected ext2spice to avoid incorrect precision when writing out 

values.  The "%.3g" format was changed to "%.*g" with a variable
precision that accounts for the actual precision required by the
manufacturing grid.
This commit is contained in:
Tim Edwards 2023-11-05 11:00:30 -05:00
parent 0894248e0a
commit 8445f3eb5d
2 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
VERSION
View File

@ -1 +1 @@
8.3.444 8.3.445

25
ext2spice/ext2spice.c
View File

@ -3105,6 +3105,7 @@ esSIvalue(file, value)
float value; float value;
{ {
char suffix = '\0'; char suffix = '\0';
int precision;
float avalue; float avalue;
avalue = fabsf(value); avalue = fabsf(value);
@ -3150,10 +3151,30 @@ esSIvalue(file, value)
value /= 1.0E3; value /= 1.0E3;
} }
/* Note that "%g" is preferred because it produces more readable
* output. However, it changes the definition of the precision
* from significant digits after the radix to total significant
* digits. Determine the proper precision to use by reading
* back the formatted value and comparing to the original value.
*/
for (precision = 3; precision < 9; precision++)
{
int vtrunc, ptrunc;
char ptest[32];
float pvalue;
sprintf(ptest, "%.*g", value, precision);
sscanf(ptest, "%f", &pvalue);
vtrunc = (int)(0.5 + (value * 1e6));
ptrunc = (int)(0.5 + (pvalue * 1e6));
if (vtrunc == ptrunc) break;
}
if (suffix == '\0') if (suffix == '\0')
fprintf(file, "%.3g", value); fprintf(file, "%.*g", value, precision);
else else
fprintf(file, "%.3g%c", value, suffix); fprintf(file, "%.3*%c", value, precision, suffix);
} }
/* /*