luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CodeQL MemoryMayNotBeFreed.ql antennacheckVisit() 

Looks like straight forward exit path doesn't cleanup locally malloc
block.
This commit is contained in:
Darryl L. Miles 2025-02-13 08:29:35 +00:00 committed by Tim Edwards
parent 7508a9e6b7
commit 822a95ab35
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
extflat/EFantenna.c
View File

@ -414,7 +414,10 @@ antennacheckVisit(dev, hc, scale, trans, editUse)
if (gnode->efnode_client == (ClientData) NULL) if (gnode->efnode_client == (ClientData) NULL)
initNodeClient(gnode); initNodeClient(gnode);
if (beenVisited((nodeClient *)gnode->efnode_client, 0)) if (beenVisited((nodeClient *)gnode->efnode_client, 0))
{
freeMagic(antennaarea);
return 0; return 0;
}
else else
markVisited((nodeClient *)gnode->efnode_client, 0); markVisited((nodeClient *)gnode->efnode_client, 0);