luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CodeQL IncorrectNotOperatorUsage.ql rtrDcmppose.c rtrCLEAR() usages 

Maybe it was a single bit and '!' operator inverted a single bit, but it
 appears to be a 4-bit mask today.

TODO check rtrMARKED() this looks like it uses '&' operator is in use
 but from the context of a bitmask maybe this should be '|' operator.
This commit is contained in:
Darryl L. Miles 2025-02-13 08:22:28 +00:00 committed by Tim Edwards
parent ca9229b35a
commit 6a537c4659
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
router/rtrDcmpose.h
View File

@ -53,6 +53,7 @@
/* rtrMARK(t,s) Tile * t; int s; /* rtrMARK(t,s) Tile * t; int s;
* Mark the indicated horizontal tile edge as a valid channel boundary. * Mark the indicated horizontal tile edge as a valid channel boundary.
* FIXME this looks suspect, maybe it should be '|' operator and not '&'.
*/ */
#define rtrMARK(t,s) \ #define rtrMARK(t,s) \
((t)->ti_client = INT2CD((((int) CD2INT((t)->ti_client))&(s)))) ((t)->ti_client = INT2CD((((int) CD2INT((t)->ti_client))&(s))))
@ -61,7 +62,7 @@
* Clear the indicated horizontal tile edge as a valid channel boundary. * Clear the indicated horizontal tile edge as a valid channel boundary.
*/ */
#define rtrCLEAR(t,s) \ #define rtrCLEAR(t,s) \
((t)->ti_client = INT2CD((((int) CD2INT((t)->ti_client))&(!s)))) ((t)->ti_client = INT2CD((((int) CD2INT((t)->ti_client))&(~s))))
/* Private Procedures */ /* Private Procedures */
int rtrSrPaint(); int rtrSrPaint();