luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ExtTech.c: fix uninitialized exts_linearResist value leaks into extresist 

This value appears to be initialised at only one spot in the codebase
(under very narrow conditions) but extresist will read it and make
branching decisions based on the uninitialised state.

This 'X' state propagation appears to eventually get processed in
ResWriteExtFile() near where final output formatting is occurring.

It is unclear (at this time) if it perturbs output values in a
problematic way, or if due to algorithmic reasons the data is
discarded before output anyway.  I have at least one trace run (with
multiple triggers) of printf formatters handling uninitialised data
in ResWriteExtFile().
This commit is contained in:
Darryl L. Miles 2025-02-26 06:27:44 +00:00 committed by R. Timothy Edwards
parent 2c9e3a558d
commit 44bb9327a2
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
extract/ExtTech.c
View File

@ -2807,6 +2807,7 @@ ExtTechLine(sectionName, argc, argv)
} }
devptr->exts_deviceResist.ht_table = (HashEntry **) NULL; devptr->exts_deviceResist.ht_table = (HashEntry **) NULL;
HashInit(&devptr->exts_deviceResist, 8, HT_STRINGKEYS); HashInit(&devptr->exts_deviceResist, 8, HT_STRINGKEYS);
devptr->exts_linearResist = 0;
devptr->exts_next = ExtCurStyle->exts_device[t]; devptr->exts_next = ExtCurStyle->exts_device[t];
ExtCurStyle->exts_device[t] = devptr; ExtCurStyle->exts_device[t] = devptr;