GHA: appimage*.yml: fetch-tags: true workaround (see actions/checkout~issue#1471)

CoPilot analysis

Bonus: fetch-tags workaround may be removable

The appimage workflows have this comment throughout:
  #fetch-tags: true # this should work see actions/checkout~issue#1471

...and then manually run git fetch --tags as a workaround. The fetch-tags input bug referenced
in issue #1471 was fixed in a v4.x patch release. After upgrading to v7, it would be worth
testing fetch-tags: true directly and removing the manual git fetch --tags workaround in the
appimage "Create RELEASE-NOTES.txt" steps — though this is independent of the version upgrade
itself.

.github/workflows/appimage10.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v7
         with:
           fetch-depth: 149 # enough to cover between tags
-          #fetch-tags: true # this should work see actions/checkout~issue#1471
+          fetch-tags: true # this should work see actions/checkout~issue#1471
 
       - name: Get the version
         id: get_version
@@ -64,17 +64,7 @@ jobs:
           # Find the last tag (that does not match the current GITHUB_REF)
           echo GITHUB_REF=$GITHUB_REF
           echo GITHUB_SHA=$GITHUB_SHA
-          # GitHub CI is a shallow checkout by default (just the files needed to build)
-          # but we also want history back to next tag, see fetch-tags/fetch-depth actions/checkout~issue#1471
-          if [[ "$GITHUB_REF" =~ ^refs/tags/ ]]
-          then
-            # remove only if ref of tag (to avoid conflict during fetch)
-            git update-ref -d $GITHUB_REF
-            echo git_update_ref_exitstatus=$?
-          fi
           set +e
-          git fetch --tags --prune --no-recurse-submodules --depth=149 origin +$GITHUB_SHA # fetch-tags: true # is broken
-          echo git_fetch_exitstatus=$?
           git_show_ref=$(git show-ref --hash $GITHUB_REF) # get tagcommit hash
           git_show_ref_exitstatus=$?
           echo git_show_ref_exitstatus=$git_show_ref_exitstatus

.github/workflows/appimage7.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v7
         with:
           fetch-depth: 149 # enough to cover between tags
-          #fetch-tags: true # this should work see actions/checkout~issue#1471
+          fetch-tags: true # this should work see actions/checkout~issue#1471
 
       - name: Get the version
         id: get_version
@@ -64,17 +64,7 @@ jobs:
           # Find the last tag (that does not match the current GITHUB_REF)
           echo GITHUB_REF=$GITHUB_REF
           echo GITHUB_SHA=$GITHUB_SHA
-          # GitHub CI is a shallow checkout by default (just the files needed to build)
-          # but we also want history back to next tag, see fetch-tags/fetch-depth actions/checkout~issue#1471
-          if [[ "$GITHUB_REF" =~ ^refs/tags/ ]]
-          then
-            # remove only if ref of tag (to avoid conflict during fetch)
-            git update-ref -d $GITHUB_REF
-            echo git_update_ref_exitstatus=$?
-          fi
           set +e
-          git fetch --tags --prune --no-recurse-submodules --depth=149 origin +$GITHUB_SHA # fetch-tags: true # is broken
-          echo git_fetch_exitstatus=$?
           git_show_ref=$(git show-ref --hash $GITHUB_REF) # get tagcommit hash
           git_show_ref_exitstatus=$?
           echo git_show_ref_exitstatus=$git_show_ref_exitstatus

.github/workflows/appimage8.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v7
         with:
           fetch-depth: 149 # enough to cover between tags
-          #fetch-tags: true # this should work see actions/checkout~issue#1471
+          fetch-tags: true # this should work see actions/checkout~issue#1471
 
       - name: Get the version
         id: get_version
@@ -64,17 +64,7 @@ jobs:
           # Find the last tag (that does not match the current GITHUB_REF)
           echo GITHUB_REF=$GITHUB_REF
           echo GITHUB_SHA=$GITHUB_SHA
-          # GitHub CI is a shallow checkout by default (just the files needed to build)
-          # but we also want history back to next tag, see fetch-tags/fetch-depth actions/checkout~issue#1471
-          if [[ "$GITHUB_REF" =~ ^refs/tags/ ]]
-          then
-            # remove only if ref of tag (to avoid conflict during fetch)
-            git update-ref -d $GITHUB_REF
-            echo git_update_ref_exitstatus=$?
-          fi
           set +e
-          git fetch --tags --prune --no-recurse-submodules --depth=149 origin +$GITHUB_SHA # fetch-tags: true # is broken
-          echo git_fetch_exitstatus=$?
           git_show_ref=$(git show-ref --hash $GITHUB_REF) # get tagcommit hash
           git_show_ref_exitstatus=$?
           echo git_show_ref_exitstatus=$git_show_ref_exitstatus

.github/workflows/appimage9.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v7
         with:
           fetch-depth: 149 # enough to cover between tags
-          #fetch-tags: true # this should work see actions/checkout~issue#1471
+          fetch-tags: true # this should work see actions/checkout~issue#1471
 
       - name: Get the version
         id: get_version
@@ -64,17 +64,7 @@ jobs:
           # Find the last tag (that does not match the current GITHUB_REF)
           echo GITHUB_REF=$GITHUB_REF
           echo GITHUB_SHA=$GITHUB_SHA
-          # GitHub CI is a shallow checkout by default (just the files needed to build)
-          # but we also want history back to next tag, see fetch-tags/fetch-depth actions/checkout~issue#1471
-          if [[ "$GITHUB_REF" =~ ^refs/tags/ ]]
-          then
-            # remove only if ref of tag (to avoid conflict during fetch)
-            git update-ref -d $GITHUB_REF
-            echo git_update_ref_exitstatus=$?
-          fi
           set +e
-          git fetch --tags --prune --no-recurse-submodules --depth=149 origin +$GITHUB_SHA # fetch-tags: true # is broken
-          echo git_fetch_exitstatus=$?
           git_show_ref=$(git show-ref --hash $GITHUB_REF) # get tagcommit hash
           git_show_ref_exitstatus=$?
           echo git_show_ref_exitstatus=$git_show_ref_exitstatus