Improve resolver error clarity and trap cleanup ordering

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
This commit is contained in:
Darryl L. Miles
2026-07-23 16:09:35 -04:00
committed by R. Timothy Edwards
co-authored by copilot-swe-agent[bot] <198982749+[email protected]>
parent a5aa32883c
commit 265fbb05ed
4 changed files with 20 additions and 8 deletions
+5 -2
View File
@@ -123,7 +123,10 @@ jobs:
echo "Using workflow_dispatch TCL ref: $tcl_ref" echo "Using workflow_dispatch TCL ref: $tcl_ref"
else else
tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1) tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1)
test -n "$tcl_ref" if [ -z "$tcl_ref" ]; then
echo "No matching Tcl tags found for pattern ${TCL_TAG_GLOB}" >&2
exit 1
fi
echo "Auto-resolved latest Tcl ref: $tcl_ref" echo "Auto-resolved latest Tcl ref: $tcl_ref"
fi fi
@@ -162,8 +165,8 @@ jobs:
fi fi
tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD) tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD)
tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci) tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci)
trap - EXIT
cleanup_tcl_tmpdir cleanup_tcl_tmpdir
trap - EXIT
else else
tcl_commit="" tcl_commit=""
tcl_commit_date="" tcl_commit_date=""
+5 -2
View File
@@ -123,7 +123,10 @@ jobs:
echo "Using workflow_dispatch TCL ref: $tcl_ref" echo "Using workflow_dispatch TCL ref: $tcl_ref"
else else
tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1) tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1)
test -n "$tcl_ref" if [ -z "$tcl_ref" ]; then
echo "No matching Tcl tags found for pattern ${TCL_TAG_GLOB}" >&2
exit 1
fi
echo "Auto-resolved latest Tcl ref: $tcl_ref" echo "Auto-resolved latest Tcl ref: $tcl_ref"
fi fi
@@ -162,8 +165,8 @@ jobs:
fi fi
tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD) tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD)
tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci) tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci)
trap - EXIT
cleanup_tcl_tmpdir cleanup_tcl_tmpdir
trap - EXIT
else else
tcl_commit="" tcl_commit=""
tcl_commit_date="" tcl_commit_date=""
+5 -2
View File
@@ -123,7 +123,10 @@ jobs:
echo "Using workflow_dispatch TCL ref: $tcl_ref" echo "Using workflow_dispatch TCL ref: $tcl_ref"
else else
tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1) tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1)
test -n "$tcl_ref" if [ -z "$tcl_ref" ]; then
echo "No matching Tcl tags found for pattern ${TCL_TAG_GLOB}" >&2
exit 1
fi
echo "Auto-resolved latest Tcl ref: $tcl_ref" echo "Auto-resolved latest Tcl ref: $tcl_ref"
fi fi
@@ -162,8 +165,8 @@ jobs:
fi fi
tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD) tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD)
tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci) tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci)
trap - EXIT
cleanup_tcl_tmpdir cleanup_tcl_tmpdir
trap - EXIT
else else
tcl_commit="" tcl_commit=""
tcl_commit_date="" tcl_commit_date=""
+5 -2
View File
@@ -123,7 +123,10 @@ jobs:
echo "Using workflow_dispatch TCL ref: $tcl_ref" echo "Using workflow_dispatch TCL ref: $tcl_ref"
else else
tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1) tcl_ref=$(retry_ls_remote "refs/tags/${TCL_TAG_GLOB}" | awk '{print $2}' | sed 's#refs/tags/##' | sort -V | tail -1)
test -n "$tcl_ref" if [ -z "$tcl_ref" ]; then
echo "No matching Tcl tags found for pattern ${TCL_TAG_GLOB}" >&2
exit 1
fi
echo "Auto-resolved latest Tcl ref: $tcl_ref" echo "Auto-resolved latest Tcl ref: $tcl_ref"
fi fi
@@ -162,8 +165,8 @@ jobs:
fi fi
tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD) tcl_commit=$(git -C "$tcl_tmpdir" rev-parse HEAD)
tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci) tcl_commit_date=$(git -C "$tcl_tmpdir" log -1 --format=%ci)
trap - EXIT
cleanup_tcl_tmpdir cleanup_tcl_tmpdir
trap - EXIT
else else
tcl_commit="" tcl_commit=""
tcl_commit_date="" tcl_commit_date=""