luke
/
magic
mirror of https://github.com/RTimothyEdwards/magic.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grX11su1.c: GrX11IconUpdate() potential -1 out-of-bound access 

SonarCloud
Access of 'char' element in the region at index -1
https://sonarcloud.io/project/issues?open=AZJB163RNGfDNup0Ri4r&id=dlmiles_magic
This commit is contained in:
Darryl L. Miles 2024-10-16 10:23:21 +01:00 committed by Tim Edwards
parent 3a35d4d28d
commit 114ddf1b0c
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
graphics/grX11su1.c
View File

@ -1441,7 +1441,9 @@ GrX11IconUpdate(w,text)
class.res_name = "magic"; class.res_name = "magic";
class.res_class = "magic"; class.res_class = "magic";
XSetClassHint( grXdpy, wind, &class); XSetClassHint( grXdpy, wind, &class);
if (brack = strchr(text,'[')) if (text == NULL)
return;
if ((brack = strchr(text,'[')) brack != text)
{ {
brack--; brack--;
*brack = 0; *brack = 0;
@ -1450,7 +1452,7 @@ GrX11IconUpdate(w,text)
*brack = ' '; *brack = ' ';
return; return;
} }
if (brack = strrchr(text,' ')) text = brack+1; if ((brack = strrchr(text,' '))) text = brack+1;
XSetIconName(grXdpy,wind,text); XSetIconName(grXdpy,wind,text);
XStoreName(grXdpy,wind,text); XStoreName(grXdpy,wind,text);
} }