luke/magic - magic - Gitea: Git with a cup of tea

2 lines

8 B

Plaintext

Raw Normal View History

Fixed an error introduced in the last commit (which has been in the code now for 10 days). The last commit fixed an error when using drcCanonicalMaxwidth() multiple times in DRC rule checks on a single edge. At the time, I also added a method to save some drcCanonicalMaxwidth() results to prevent needlessly re-doing the same (potentially expensive) computation over and over. However, where I reused the cached result, I did not check if the number of entries is zero. Other code does not check the number of entries and depends on the prior behavior that drcCanonicalMaxwidth() returns NULL when there are no entries. So the code needed to check if the number of entries is zero before re-using the cached result. Without the fix, any time the caching is used, the last computed maximum area rectangle will be made active even when the current check area does not meet the area requirement, resulting in many false positive errors.

2026-04-24 17:21:15 +02:00

8.3.638