luke
/
klayout
mirror of https://github.com/KLayout/klayout.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixing issue #2111 (internal error on tesselation R extractor) 

Problem was a runaway triangulation case where outside edges
exist without being segments.
This commit is contained in:
Matthias Koefferlein 2025-08-09 18:40:19 +02:00
parent e359f2af20
commit cb70620ad1
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/db/db/dbPLCTriangulation.cc
View File

@ -1661,7 +1661,8 @@ Triangulation::refine (const TriangulationParameters &parameters)
Edge *edge = find_closest_edge (center, vstart, true /*inside only*/);
tl_assert (edge != 0);
if (! edge->is_segment () || edge->side_of (*vstart) * edge->side_of (center) >= 0) {
if ((! edge->is_segment () && (edge->side_of (center) < 0 ? edge->left () : edge->right ()) != 0 /*center is inside*/)
|| (edge->is_segment () && edge->side_of (*vstart) * edge->side_of (center) >= 0)) {
if (tl::verbosity () >= parameters.base_verbosity + 20) {
tl::info << "Inserting out-of-triangle center " << center << " of " << (*t)->to_string (true);

34
src/pex/unit_tests/pexTriangulationRExtractorTests.cc
View File

@ -361,3 +361,37 @@ TEST(extraction_meander)
)
}
TEST(extraction_issue2111)
{
db::Point contour[] = {
db::Point (0, 0),
db::Point (0, 740),
db::Point (435, 740),
db::Point (435, 100),
db::Point (365, 100),
db::Point (365, 0)
};
db::Polygon poly;
poly.assign_hull (contour + 0, contour + sizeof (contour) / sizeof (contour[0]));
double dbu = 0.001;
pex::RNetwork rn;
pex::TriangulationRExtractor rex (dbu);
// rex.triangulation_parameters ().max_area = 10000 * dbu * dbu;
// rex.triangulation_parameters ().min_b = 0.3;
std::vector<db::Point> vertex_ports;
vertex_ports.push_back (db::Point (400, 500));
std::vector<db::Polygon> polygon_ports;
polygon_ports.push_back (poly);
rex.extract (poly, vertex_ports, polygon_ports, rn);
EXPECT_EQ (rn.to_string (),
"R P0 V0 0.133103"
)
}