Tiny bugfix: don't waste CPU time in a dialog exec loop.

This commit is contained in:
Matthias Koefferlein 2017-10-09 00:21:13 +02:00
parent 6c952921ea
commit 93b30364d9
2 changed files with 5 additions and 7 deletions

View File

@ -37,7 +37,7 @@ namespace lay
// ----------------------------------------------------------------------------------
ConfirmationDialog::ConfirmationDialog (QWidget *parent)
: QDialog (parent), m_confirmed (false), m_cancelled (false), m_closed (false), m_file (50000, true)
: QDialog (parent), m_confirmed (false), m_cancelled (false), m_file (50000, true)
{
Ui::SaltManagerInstallConfirmationDialog::setupUi (this);
@ -419,9 +419,8 @@ SaltDownloadManager::execute (lay::SaltManagerDialog *parent, lay::Salt &salt)
dialog->finish ();
while (! dialog->is_closed () && dialog->isVisible ()) {
QCoreApplication::processEvents (QEventLoop::AllEvents | QEventLoop::WaitForMoreEvents, 100);
}
// Show the dialog until it's closed
dialog->exec ();
} else {

View File

@ -52,7 +52,6 @@ public:
bool is_confirmed () const { return m_confirmed; }
bool is_cancelled () const { return m_cancelled; }
bool is_closed () const { return m_closed; }
void start ();
void separator ();
@ -64,10 +63,10 @@ public:
private slots:
void confirm_pressed () { m_confirmed = true; }
void cancel_pressed () { m_cancelled = true; }
void close_pressed () { m_closed = true; }
void close_pressed () { hide (); }
private:
bool m_confirmed, m_cancelled, m_closed;
bool m_confirmed, m_cancelled;
lay::LogFile m_file;
std::map<std::string, QTreeWidgetItem *> m_items_by_name;