luke
/
klayout
mirror of https://github.com/KLayout/klayout.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

WIP: bugfix - PCell parameter page wasn't updated initially

This commit is contained in:
Matthias Koefferlein 2020-08-10 10:32:01 +02:00
parent a1443a8018
commit 701f690053
6 changed files with 8 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/edt/edt/EditorOptionsPath.ui
View File

@ -56,7 +56,7 @@
<item>
<widget class="QLabel" name="label_2">
<property name="text">
<string> Width </string>
<string>Width</string>
</property>
</widget>
</item>

2
src/edt/edt/edtEditorOptionsPages.cc
View File

@ -873,7 +873,7 @@ EditorOptionsInstPCellParam::setup (lay::Plugin *root)
std::vector<tl::Variant> pv;
if (layout && mp_pcell_parameters) {
if (layout) {
std::pair<bool, db::pcell_id_type> pc = layout->pcell_by_name (tl::to_string (m_cell_name).c_str ());

6
src/edt/edt/edtMainService.cc
View File

@ -2269,12 +2269,6 @@ MainService::cm_change_layer ()
}
void
MainService::show_editor_options ()
{
show_editor_options_page (view ());
}
void
MainService::check_no_guiding_shapes ()
{

5
src/edt/edt/edtMainService.h
View File

@ -189,11 +189,6 @@ public:
*/
void cm_tap ();
/**
* @brief Shows the editor options
*/
void show_editor_options ();
/**
* @brief "paste" operation
*/

6
src/edt/edt/edtService.cc
View File

@ -796,10 +796,16 @@ void
Service::activated ()
{
if (view ()->is_editable ()) {
view ()->cancel (); // cancel any pending edit operations and clear the selection
set_edit_marker (0);
m_immediate = do_activated ();
m_editing = false;
// Show editor options panel
show_editor_options_page (view ());
}
// make all editor option pages visible

18
src/edt/edt/edtServiceImpl.cc
View File

@ -749,12 +749,6 @@ TextService::do_activated ()
{
m_rot = 0;
// Show editor options dialog to allow entering of width
std::vector<edt::MainService *> edt_main_services = view ()->get_plugins <edt::MainService> ();
if (edt_main_services.size () > 0) {
edt_main_services [0]->show_editor_options ();
}
return true; // start editing immediately
}
@ -915,12 +909,6 @@ PathService::do_begin_edit (const db::DPoint &p)
bool
PathService::do_activated ()
{
// Show editor options dialog to allow entering of width
std::vector<edt::MainService *> edt_main_services = view ()->get_plugins <edt::MainService> ();
if (edt_main_services.size () > 0) {
edt_main_services [0]->show_editor_options ();
}
return false; // don't start editing immediately
}
@ -1120,12 +1108,6 @@ InstService::properties_page (db::Manager *manager, QWidget *parent)
bool
InstService::do_activated ()
{
// Show editor options dialog to allow entering of parameters
std::vector<edt::MainService *> edt_main_services = view ()->get_plugins <edt::MainService> ();
if (edt_main_services.size () > 0) {
edt_main_services [0]->show_editor_options ();
}
m_cv_index = view ()->active_cellview_index ();
m_has_valid_cell = false;