luke/klayout
1
0
Fork 0
mirror of https://github.com/KLayout/klayout.git synced 2026-09-07 19:51:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed a bug in PCell parameter computation

Browse Source 
"coerce_parameters" and "callback" was called with the client layout
instead of definition layout, hence the DBU was incorrect if both layouts have different DBU.

This became visible on the computed character dimensions of the Basic.TEXT
PCell when the client layout had a DBU != 1nm.
This commit is contained in:
Matthias Koefferlein
2026-04-04 14:40:36 +02:00
parent 57eb90df69
commit 65fec36902
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/edt/edt/edtPCellParametersPage.cc
+11 -5
View File
@@ -699,7 +699,9 @@ PCellParametersPage::setup (lay::LayoutViewBase *view, int cv_index, const db::P
// initial callback
try {
mp_pcell_decl->callback (mp_view->cellview (m_cv_index)->layout (), std::string (), m_states);
if (mp_pcell_decl->layout ()) {
mp_pcell_decl->callback (*mp_pcell_decl->layout (), std::string (), m_states);
}
} catch (tl::Exception &ex) {
// potentially caused by script errors in callback implementation
tl::error << ex.msg ();
@@ -788,7 +790,9 @@ PCellParametersPage::parameter_changed ()
// Note: checking for is_busy prevents callbacks during debugger execution
if (! edit_error) {
mp_pcell_decl->callback (mp_view->cellview (m_cv_index)->layout (), pd ? pd->get_name () : std::string (), states);
if (mp_pcell_decl->layout ()) {
mp_pcell_decl->callback (*mp_pcell_decl->layout (), pd ? pd->get_name () : std::string (), states);
}
m_states = states;
}
@@ -1014,7 +1018,9 @@ PCellParametersPage::get_parameters (db::ParameterStates &states, bool *ok)
auto parameters = parameter_from_states (states);
auto before_coerce = parameters;
mp_pcell_decl->coerce_parameters (mp_view->cellview (m_cv_index)->layout (), parameters);
if (mp_pcell_decl->layout ()) {
mp_pcell_decl->coerce_parameters (*mp_pcell_decl->layout (), parameters);
}
if (parameters != before_coerce) {
states_from_parameters (states, parameters);
@@ -1070,8 +1076,8 @@ PCellParametersPage::set_parameters (const std::vector<tl::Variant> &parameters)
states_from_parameters (m_states, parameters);
try {
if (mp_view->cellview (m_cv_index).is_valid ()) {
mp_pcell_decl->callback (mp_view->cellview (m_cv_index)->layout (), std::string (), m_states);
if (mp_view->cellview (m_cv_index).is_valid () && mp_pcell_decl->layout ()) {
mp_pcell_decl->callback (*mp_pcell_decl->layout (), std::string (), m_states);
}
} catch (tl::Exception &ex) {
// potentially caused by script errors in callback implementation