luke
/
klayout
mirror of https://github.com/KLayout/klayout.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed issue #321 

This is a small paradigm shift in the configuration hierarchy:
plugins (as children of root) now inherit the configuration
from the parent - now only through configure, but also through
config_get (pull with config_get vs. push with configure).

TODO: both methods are not entirely consistent as configure
can block propagation of configuration settings. But that's a
feature hardly used anyway and rather an optimization thing.
This commit is contained in:
Matthias Koefferlein 2019-08-17 14:49:15 +02:00
parent e33c2f7b66
commit 06a1cafdf4
3 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/laybasic/laybasic/layNetlistBrowserDialog.cc
View File

@ -674,9 +674,7 @@ void
NetlistBrowserDialog::activated ()
{
std::string state;
if (lay::PluginRoot::instance ()) {
lay::PluginRoot::instance ()->config_get (cfg_l2ndb_window_state, state);
}
view ()->config_get (cfg_l2ndb_window_state, state);
lay::restore_dialog_state (this, state, false /*don't adjust the section sizes*/);
// Switch to the active cellview index when no valid one is set.

2
src/laybasic/laybasic/layPlugin.cc
View File

@ -346,6 +346,8 @@ Plugin::config_get (const std::string &name, std::string &value) const
if (p != m_repository.end ()) {
value = p->second;
return true;
} else if (mp_parent) {
return mp_parent->config_get (name, value);
} else {
value = "";
return false;

4
src/laybasic/laybasic/rdbMarkerBrowserDialog.cc
View File

@ -636,9 +636,7 @@ void
MarkerBrowserDialog::activated ()
{
std::string state;
if (lay::PluginRoot::instance ()) {
lay::PluginRoot::instance ()->config_get (cfg_rdb_window_state, state);
}
view ()->config_get (cfg_rdb_window_state, state);
lay::restore_dialog_state (this, state);
// Switch to the active cellview index when no valid one is set.