luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Convert a few sprintfs to snprintf 

This patch converts a few sprintf statements to snprintf
to protect against buffer overflow.

It also converts a few sizeof calls from sizeof(x) to
sizeof x like other places in the code.
This commit is contained in:
Cary R 2009-11-30 19:14:39 -08:00 committed by Stephen Williams
parent 849b241ffa
commit f44c1cadde
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
driver/main.c
View File

@ -150,8 +150,7 @@ FILE*iconfig_file = 0;
char*compiled_defines_path = 0; char*compiled_defines_path = 0;
static char iconfig_common_path_buf[4096] = ""; static char iconfig_common_path[4096] = "";
char*iconfig_common_path = iconfig_common_path_buf;
int synth_flag = 0; int synth_flag = 0;
int verbose_flag = 0; int verbose_flag = 0;
@ -268,7 +267,8 @@ static const char*my_tempfile(const char*str, FILE**fout)
file = NULL; file = NULL;
while ((retry > 0) && (file == NULL)) { while ((retry > 0) && (file == NULL)) {
unsigned code = rand(); unsigned code = rand();
sprintf(pathbuf, "%s%c%s%04x", tmpdir, sep, str, code); snprintf(pathbuf, sizeof pathbuf, "%s%c%s%04x",
tmpdir, sep, str, code);
file = fopen_safe(pathbuf); file = fopen_safe(pathbuf);
retry -= 1; retry -= 1;
} }
@ -754,7 +754,7 @@ int main(int argc, char **argv)
#ifdef __MINGW32__ #ifdef __MINGW32__
{ char * s; { char * s;
char basepath[1024], tmp[1024]; char basepath[1024], tmp[1024];
GetModuleFileName(NULL, tmp, sizeof(tmp)); GetModuleFileName(NULL, tmp, sizeof tmp);
/* Calculate the ivl_root from the path to the command. This /* Calculate the ivl_root from the path to the command. This
is necessary because of the installation process in is necessary because of the installation process in
@ -772,7 +772,7 @@ int main(int argc, char **argv)
the lib\ivl to finish. */ the lib\ivl to finish. */
/* Convert to a short name to remove any embedded spaces. */ /* Convert to a short name to remove any embedded spaces. */
GetShortPathName(tmp, basepath, sizeof(basepath)); GetShortPathName(tmp, basepath, sizeof basepath);
strncpy(ivl_root, basepath, MAXSIZE); strncpy(ivl_root, basepath, MAXSIZE);
s = strrchr(ivl_root, sep); s = strrchr(ivl_root, sep);
if (s) *s = 0; if (s) *s = 0;
@ -984,7 +984,7 @@ int main(int argc, char **argv)
} }
/* Make a common conf file path to reflect the target. */ /* Make a common conf file path to reflect the target. */
sprintf(iconfig_common_path, "%s%c%s%s.conf", snprintf(iconfig_common_path, sizeof iconfig_common_path, "%s%c%s%s.conf",
base,sep, targ, synth_flag? "-s" : ""); base,sep, targ, synth_flag? "-s" : "");
/* Write values to the iconfig file. */ /* Write values to the iconfig file. */