luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Report the lines that have delay or event control in an always_comb/ff/latch process

This commit is contained in:
Cary R 2017-12-06 00:21:24 -08:00
parent cb0ffd734e
commit f17992bcd0
3 changed files with 53 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
elaborate.cc
View File

@ -6151,7 +6151,7 @@ bool Design::check_proc_delay() const
<< "first statement of an always_ff must " << "first statement of an always_ff must "
<< "be an event control." << endl; << "be an event control." << endl;
result_flag = false; result_flag = false;
} else if (wait->statement()->delay_type() != NO_DELAY) { } else if (wait->statement()->delay_type(true) != NO_DELAY) {
cerr << pr->get_fileline() << ": error: there " cerr << pr->get_fileline() << ": error: there "
<< "must "; << "must ";

68
netlist.cc
View File

@ -2768,7 +2768,7 @@ static DelayType delay_type_from_expr(const NetExpr*expr)
* The looping structures can use the same basic code so put it here * The looping structures can use the same basic code so put it here
* instead of duplicating it for each one (repeat and while). * instead of duplicating it for each one (repeat and while).
*/ */
static DelayType get_loop_delay_type(const NetExpr*expr, const NetProc*proc) static DelayType get_loop_delay_type(const NetExpr*expr, const NetProc*proc, bool print_delay)
{ {
DelayType result; DelayType result;
@ -2779,12 +2779,12 @@ static DelayType get_loop_delay_type(const NetExpr*expr, const NetProc*proc)
break; break;
/* We have a constant true expression so the body always runs. */ /* We have a constant true expression so the body always runs. */
case DEFINITE_DELAY: case DEFINITE_DELAY:
result = proc->delay_type(); result = proc->delay_type(print_delay);
break; break;
/* We don't know if the body will run so reduce a DEFINITE_DELAY /* We don't know if the body will run so reduce a DEFINITE_DELAY
* to a POSSIBLE_DELAY. All other stay the same. */ * to a POSSIBLE_DELAY. All other stay the same. */
case POSSIBLE_DELAY: case POSSIBLE_DELAY:
result = combine_delays(NO_DELAY, proc->delay_type()); result = combine_delays(NO_DELAY, proc->delay_type(print_delay));
break; break;
/* This should never happen since delay_type_from_expr() only /* This should never happen since delay_type_from_expr() only
* returns three different values. */ * returns three different values. */
@ -2797,12 +2797,12 @@ static DelayType get_loop_delay_type(const NetExpr*expr, const NetProc*proc)
} }
/* The default object does not have any delay. */ /* The default object does not have any delay. */
DelayType NetProc::delay_type() const DelayType NetProc::delay_type(bool /* print_delay */ ) const
{ {
return NO_DELAY; return NO_DELAY;
} }
DelayType NetBlock::delay_type() const DelayType NetBlock::delay_type(bool print_delay) const
{ {
// A join_none has no delay. // A join_none has no delay.
if (type() == PARA_JOIN_NONE) return NO_DELAY; if (type() == PARA_JOIN_NONE) return NO_DELAY;
@ -2812,7 +2812,7 @@ DelayType NetBlock::delay_type() const
if (type() == PARA_JOIN_ANY) { if (type() == PARA_JOIN_ANY) {
result = DEFINITE_DELAY; result = DEFINITE_DELAY;
for (const NetProc*cur = proc_first(); cur; cur = proc_next(cur)) { for (const NetProc*cur = proc_first(); cur; cur = proc_next(cur)) {
DelayType dt = cur->delay_type(); DelayType dt = cur->delay_type(print_delay);
if (dt < result) result = dt; if (dt < result) result = dt;
if (dt == NO_DELAY) break; if (dt == NO_DELAY) break;
} }
@ -2821,7 +2821,7 @@ DelayType NetBlock::delay_type() const
} else { } else {
result = NO_DELAY; result = NO_DELAY;
for (const NetProc*cur = proc_first(); cur; cur = proc_next(cur)) { for (const NetProc*cur = proc_first(); cur; cur = proc_next(cur)) {
DelayType dt = cur->delay_type(); DelayType dt = cur->delay_type(print_delay);
if (dt > result) result = dt; if (dt > result) result = dt;
if (dt == DEFINITE_DELAY) break; if (dt == DEFINITE_DELAY) break;
} }
@ -2830,7 +2830,7 @@ DelayType NetBlock::delay_type() const
return result; return result;
} }
DelayType NetCase::delay_type() const DelayType NetCase::delay_type(bool print_delay) const
{ {
DelayType result = NO_DELAY; DelayType result = NO_DELAY;
bool def_stmt = false; bool def_stmt = false;
@ -2838,7 +2838,7 @@ DelayType NetCase::delay_type() const
for (unsigned idx = 0; idx < nstmts; idx += 1) { for (unsigned idx = 0; idx < nstmts; idx += 1) {
if (!expr(idx)) def_stmt = true; if (!expr(idx)) def_stmt = true;
DelayType dt = stat(idx) ? stat(idx)->delay_type() : NO_DELAY; DelayType dt = stat(idx) ? stat(idx)->delay_type(print_delay) : NO_DELAY;
if (idx == 0) { if (idx == 0) {
result = dt; result = dt;
} else { } else {
@ -2853,41 +2853,51 @@ DelayType NetCase::delay_type() const
return result; return result;
} }
DelayType NetCondit::delay_type() const DelayType NetCondit::delay_type(bool print_delay) const
{ {
DelayType if_type = if_ ? if_->delay_type() : NO_DELAY; DelayType if_type = if_ ? if_->delay_type(print_delay) : NO_DELAY;
DelayType el_type = else_? else_->delay_type() : NO_DELAY; DelayType el_type = else_? else_->delay_type(print_delay) : NO_DELAY;
return combine_delays(if_type, el_type); return combine_delays(if_type, el_type);
} }
/* /*
* A do/while will execute the body at least once. * A do/while will execute the body at least once.
*/ */
DelayType NetDoWhile::delay_type() const DelayType NetDoWhile::delay_type(bool print_delay) const
{ {
ivl_assert(*this, proc_); ivl_assert(*this, proc_);
return proc_->delay_type(); return proc_->delay_type(print_delay);
} }
DelayType NetEvWait::delay_type() const DelayType NetEvWait::delay_type(bool print_delay) const
{ {
if (print_delay) {
cerr << get_fileline() << ": error: an event control is not allowed "
<< "in an always_comb, always_ff or always_latch process."
<< endl;
}
return DEFINITE_DELAY; return DEFINITE_DELAY;
} }
DelayType NetForever::delay_type() const DelayType NetForever::delay_type(bool print_delay) const
{ {
ivl_assert(*this, statement_); ivl_assert(*this, statement_);
return statement_->delay_type(); return statement_->delay_type(print_delay);
} }
DelayType NetForLoop::delay_type() const DelayType NetForLoop::delay_type(bool print_delay) const
{ {
ivl_assert(*this, statement_); ivl_assert(*this, statement_);
return get_loop_delay_type(condition_, statement_); return get_loop_delay_type(condition_, statement_, print_delay);
} }
DelayType NetPDelay::delay_type() const DelayType NetPDelay::delay_type(bool print_delay) const
{ {
if (print_delay) {
cerr << get_fileline() << ": error: a blocking delay is not allowed "
<< "in an always_comb, always_ff or always_latch process."
<< endl;
}
if (expr_) { if (expr_) {
return delay_type_from_expr(expr_); return delay_type_from_expr(expr_);
} else { } else {
@ -2896,7 +2906,7 @@ DelayType NetPDelay::delay_type() const
} else { } else {
if (statement_) { if (statement_) {
return combine_delays(ZERO_DELAY, return combine_delays(ZERO_DELAY,
statement_->delay_type()); statement_->delay_type(print_delay));
} else { } else {
return ZERO_DELAY; return ZERO_DELAY;
} }
@ -2904,24 +2914,24 @@ DelayType NetPDelay::delay_type() const
} }
} }
DelayType NetRepeat::delay_type() const DelayType NetRepeat::delay_type(bool print_delay) const
{ {
ivl_assert(*this, statement_); ivl_assert(*this, statement_);
return get_loop_delay_type(expr_, statement_); return get_loop_delay_type(expr_, statement_, print_delay);
} }
DelayType NetTaskDef::delay_type() const DelayType NetTaskDef::delay_type(bool print_delay) const
{ {
return proc_->delay_type(); return proc_->delay_type(print_delay);
} }
DelayType NetUTask::delay_type() const DelayType NetUTask::delay_type(bool print_delay) const
{ {
return task()->task_def()->delay_type(); return task()->task_def()->delay_type(print_delay);
} }
DelayType NetWhile::delay_type() const DelayType NetWhile::delay_type(bool print_delay) const
{ {
ivl_assert(*this, proc_); ivl_assert(*this, proc_);
return get_loop_delay_type(cond_, proc_); return get_loop_delay_type(cond_, proc_, print_delay);
} }

26
netlist.h
View File

@ -2715,7 +2715,7 @@ class NetProc : public virtual LineInfo {
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
// Recursively checks to see if there is delay in this element. // Recursively checks to see if there is delay in this element.
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
protected: protected:
bool synth_async_block_substatement_(Design*des, NetScope*scope, bool synth_async_block_substatement_(Design*des, NetScope*scope,
@ -3018,7 +3018,7 @@ class NetBlock : public NetProc {
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual int match_proc(struct proc_match_t*); virtual int match_proc(struct proc_match_t*);
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
private: private:
const Type type_; const Type type_;
@ -3065,7 +3065,7 @@ class NetCase : public NetProc {
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3155,7 +3155,7 @@ class NetCondit : public NetProc {
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual int match_proc(struct proc_match_t*); virtual int match_proc(struct proc_match_t*);
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3256,7 +3256,7 @@ class NetDoWhile : public NetProc {
virtual void nex_output(NexusSet&); virtual void nex_output(NexusSet&);
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3439,7 +3439,7 @@ class NetEvWait : public NetProc {
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
// This will ignore any statement. // This will ignore any statement.
virtual void dump_inline(ostream&) const; virtual void dump_inline(ostream&) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
private: private:
NetProc*statement_; NetProc*statement_;
@ -3509,7 +3509,7 @@ class NetForever : public NetProc {
virtual NexusSet* nex_input(bool rem_out = true, bool search_funcs = false) const; virtual NexusSet* nex_input(bool rem_out = true, bool search_funcs = false) const;
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3532,7 +3532,7 @@ class NetForLoop : public NetProc {
virtual void nex_output(NexusSet&); virtual void nex_output(NexusSet&);
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3633,7 +3633,7 @@ class NetPDelay : public NetProc {
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
bool emit_proc_recurse(struct target_t*) const; bool emit_proc_recurse(struct target_t*) const;
@ -3658,7 +3658,7 @@ class NetRepeat : public NetProc {
virtual NexusSet* nex_input(bool rem_out = true, bool search_funcs = false) const; virtual NexusSet* nex_input(bool rem_out = true, bool search_funcs = false) const;
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;
@ -3739,7 +3739,7 @@ class NetTaskDef : public NetBaseDef {
~NetTaskDef(); ~NetTaskDef();
void dump(ostream&, unsigned) const; void dump(ostream&, unsigned) const;
DelayType delay_type() const; DelayType delay_type(bool print_delay=false) const;
private: // not implemented private: // not implemented
NetTaskDef(const NetTaskDef&); NetTaskDef(const NetTaskDef&);
@ -3856,7 +3856,7 @@ class NetUTask : public NetProc {
virtual void nex_output(NexusSet&); virtual void nex_output(NexusSet&);
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
private: private:
NetScope*task_; NetScope*task_;
@ -3881,7 +3881,7 @@ class NetWhile : public NetProc {
virtual void nex_output(NexusSet&); virtual void nex_output(NexusSet&);
virtual bool emit_proc(struct target_t*) const; virtual bool emit_proc(struct target_t*) const;
virtual void dump(ostream&, unsigned ind) const; virtual void dump(ostream&, unsigned ind) const;
virtual DelayType delay_type() const; virtual DelayType delay_type(bool print_delay=false) const;
virtual bool evaluate_function(const LineInfo&loc, virtual bool evaluate_function(const LineInfo&loc,
map<perm_string,LocalVar>&ctx) const; map<perm_string,LocalVar>&ctx) const;