Make sure to call vpi_config.h first.

vpi_config.h defines _FILE_OFFSET_BITS. This must be defined before
any system includes files are processed, so vpi_config.h must be
called first. This patch puts vpi_config.h first. It also removes
direct calls for both vpi_config.h and vpi_user.h when sys_priv.h
is included since it already includes these two files.

It also updates the code to always include vpi_user.h using double
quotes.

vpi/sys_clog2.c

@@ -19,7 +19,7 @@
 #include <assert.h>
 #include <math.h>
 #include <string.h>
-#include <vpi_user.h>
+#include "vpi_user.h"
 
 /*
  * This routine returns 1 if the argument supports has a numeric value,

vpi/sys_convert.c

@@ -17,8 +17,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include  "vpi_config.h"
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <stdio.h>
 # include  <string.h>

vpi/sys_deposit.c

@@ -18,8 +18,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include  "vpi_config.h"
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <assert.h>
 # include  <string.h>

vpi/sys_display.c

@@ -17,9 +17,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include "vpi_config.h"
-
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <assert.h>
 # include  <string.h>

vpi/sys_fileio.c

@@ -17,7 +17,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <assert.h>
 # include  <ctype.h>

vpi/sys_finish.c

@@ -17,8 +17,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-#include "vpi_config.h"
-#include "vpi_user.h"
 #include "sys_priv.h"
 #include <string.h>
 

vpi/sys_icarus.c

@@ -16,9 +16,8 @@
  *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#include <assert.h>
-#include <vpi_user.h>
 #include "sys_priv.h"
+#include <assert.h>
 
 static PLI_INT32 finish_and_return_calltf(PLI_BYTE8* name)
 {

vpi/sys_lxt.c

@@ -17,10 +17,9 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-/* The vpi_config.h include must be before the lxt_write.h include! */
-# include "vpi_config.h"
-# include "lxt_write.h"
+/* The sys_priv.h include must be before the lxt_write.h include! */
 # include "sys_priv.h"
+# include "lxt_write.h"
 # include "vcd_priv.h"
 
 /*
@@ -28,7 +27,6 @@
  * funcitons.
  */
 
-# include  "vpi_user.h"
 # include  <stdio.h>
 # include  <stdlib.h>
 # include  <string.h>

vpi/sys_lxt2.c

@@ -17,10 +17,9 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-/* The vpi_config.h include must be before the lxt2_write.h include! */
-# include "vpi_config.h"
-# include "lxt2_write.h"
+/* The sys_priv.h include must be before the lxt2_write.h include! */
 # include "sys_priv.h"
+# include "lxt2_write.h"
 # include "vcd_priv.h"
 
 /*
@@ -28,7 +27,6 @@
  * funcitons.
  */
 
-# include  "vpi_user.h"
 # include  <stdio.h>
 # include  <stdlib.h>
 # include  <string.h>

vpi/sys_plusargs.c

@@ -18,7 +18,6 @@
  */
 
 # include  "sys_priv.h"
-# include  <vpi_user.h>
 # include  <string.h>
 # include  <stdlib.h>
 # include  <assert.h>

vpi/sys_priv.c

@@ -17,11 +17,11 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
+#include "sys_priv.h"
 #include <assert.h>
 #include <ctype.h>
 #include <stdlib.h>
 #include <string.h>
-#include "sys_priv.h"
 
 PLI_UINT64 timerec_to_time64(const struct t_vpi_time*time)
 {

vpi/sys_random.c

@@ -20,7 +20,6 @@
 # include "sys_priv.h"
 # include "sys_random.h"
 
-# include  <vpi_user.h>
 # include  <assert.h>
 # include  <stdlib.h>
 # include  <math.h>

vpi/sys_random_mti.c

@@ -20,7 +20,6 @@
 # include "sys_priv.h"
 # include "sys_random.h"
 
-# include  <vpi_user.h>
 # include  <assert.h>
 # include  <stdlib.h>
 # include  <math.h>

vpi/sys_readmem.c

@@ -17,9 +17,6 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include "vpi_config.h"
-
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <ctype.h>
 # include  <string.h>

vpi/sys_scanf.c

@@ -21,7 +21,6 @@
 # define _ISOC99_SOURCE 1
 # define _SVID_SOURCE 1
 
-# include  "vpi_user.h"
 # include  "sys_priv.h"
 # include  <ctype.h>
 # include  <errno.h>

vpi/sys_sdf.c

@@ -17,11 +17,8 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-# include "vpi_config.h"
-
-# include  "vpi_user.h"
-# include  "sdf_priv.h"
 # include  "sys_priv.h"
+# include  "sdf_priv.h"
 # include  <stdlib.h>
 # include  <string.h>
 # include  <assert.h>

vpi/sys_time.c

@@ -17,13 +17,10 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-#include "vpi_config.h"
-
-#include "vpi_user.h"
+#include "sys_priv.h"
 #include <string.h>
 #include <math.h>
 #include <assert.h>
-#include <sys_priv.h>
 
 static PLI_INT32 sys_time_calltf(PLI_BYTE8*name)
 {

vpi/sys_vcd.c

@@ -25,7 +25,6 @@
  * funcitons.
  */
 
-# include  "vpi_user.h"
 # include  <stdio.h>
 # include  <stdlib.h>
 # include  <string.h>

vpi/sys_vcdoff.c

@@ -23,7 +23,6 @@
  * This file contains do nothing stubs of all the VCD routines.
  */
 
-# include  "vpi_user.h"
 # include  <stdio.h>
 # include  <stdlib.h>
 # include  <string.h>

vpi/v2005_math.c

@@ -24,7 +24,7 @@
 #include <math.h>
 #include <stdlib.h>
 #include <string.h>
-#include <vpi_user.h>
+#include "vpi_user.h"
 
 /* Single argument functions. */
 typedef struct s_single_data {

vpi/va_math.c

@@ -24,7 +24,7 @@
 #include <math.h>
 #include <stdlib.h>
 #include <string.h>
-#include <vpi_user.h>
+#include "vpi_user.h"
 
 /*
  * Compile time options: (set in the Makefile.)

vpi/vams_simparam.c

@@ -16,6 +16,7 @@
  *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include "sys_priv.h"
 #include <assert.h>
 #ifdef HAVE_MALLOC_H
 # include <malloc.h>
@@ -24,8 +25,6 @@
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
-#include <vpi_user.h>
-#include "sys_priv.h"
 #include "version_base.h"
 
 /* Once we have real string objects replace this with a dynamic string. */

vpi/vcd_priv.c

@@ -17,7 +17,7 @@
  *    Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
  */
 
-#include  "vpi_config.h"
+#include  "sys_priv.h"
 #include  "vcd_priv.h"
 #include  <stdio.h>
 #include  <stdlib.h>
@@ -28,7 +28,6 @@
 #endif
 #include  <ctype.h>
 #include  "stringheap.h"
-#include  <sys_priv.h>
 
 int is_escaped_id(const char *name)
 {