Rearrange compiler warning flags
Before this patch, WARNING_FLAGS applied to both C and C++, and WARNING_FLAGS_CXX applied to C++ only. This patch adds a WARNING_FLAGS_CC that applies to C only. That change should be generally useful; in particular the C code is almost ready for -Wstrict-prototypes, which does not apply to C++. -Wextra (or -W) used to only apply to C++ via WARNING_FLAGS_CXX. This patch moves it to WARNING_FLAGS, to apply to both C and C++. Unfortunately, that triggers a ton of warnings. For now, cover most of the new warnings up by adding -Wno-unused -Wno-sign-compare -Wno-type-limits to WARNING_FLAGS_CC. In the long run, I want to change the C coding style, and take off these disable-warning flags. But those changes can dribble in as separate commits; this patch is big enough already. Actually fix a couple missing-field-initializers in libveriuser/veriusertfs.c.
This commit is contained in:
parent
a575eeb29d
commit
e221a8ced9
|
|
@ -68,7 +68,7 @@ dllib=@DLLIB@
|
||||||
|
|
||||||
# For a cross compile these defines will need to be set accordingly.
|
# For a cross compile these defines will need to be set accordingly.
|
||||||
HOSTCC = @CC@
|
HOSTCC = @CC@
|
||||||
HOSTCFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
HOSTCFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
|
|
||||||
CC = @CC@
|
CC = @CC@
|
||||||
CXX = @CXX@
|
CXX = @CXX@
|
||||||
|
|
@ -90,7 +90,7 @@ INCLUDE_PATH = -I. -I$(srcdir) -I$(srcdir)/libmisc
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = @DEFS@ $(INCLUDE_PATH) @CPPFLAGS@
|
CPPFLAGS = @DEFS@ $(INCLUDE_PATH) @CPPFLAGS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
||||||
PICFLAGS = @PICFLAG@
|
PICFLAGS = @PICFLAG@
|
||||||
LDFLAGS = @rdynamic@ @LDFLAGS@
|
LDFLAGS = @rdynamic@ @LDFLAGS@
|
||||||
|
|
|
||||||
|
|
@ -43,7 +43,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = cadpli.o
|
O = cadpli.o
|
||||||
|
|
|
||||||
|
|
@ -81,8 +81,9 @@ AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])],
|
||||||
CFLAGS="$iverilog_temp_cflags"
|
CFLAGS="$iverilog_temp_cflags"
|
||||||
|
|
||||||
AC_SUBST(DEPENDENCY_FLAG, [-MD])
|
AC_SUBST(DEPENDENCY_FLAG, [-MD])
|
||||||
AC_SUBST(WARNING_FLAGS, ["-Wall -Wshadow"])
|
AC_SUBST(WARNING_FLAGS, ["-Wall $iverilog_wextra_flag -Wshadow"])
|
||||||
AC_SUBST(WARNING_FLAGS_CXX, ["$iverilog_wextra_flag"])
|
AC_SUBST(WARNING_FLAGS_CC, ["-Wno-unused -Wno-sign-compare -Wno-type-limits"])
|
||||||
|
AC_SUBST(WARNING_FLAGS_CXX, [""])
|
||||||
fi
|
fi
|
||||||
|
|
||||||
AC_LANG(C++)
|
AC_LANG(C++)
|
||||||
|
|
|
||||||
|
|
@ -48,7 +48,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = main.o res.o
|
O = main.o res.o
|
||||||
|
|
|
||||||
|
|
@ -49,7 +49,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = main.o substit.o cflexor.o cfparse.o
|
O = main.o substit.o cflexor.o cfparse.o
|
||||||
|
|
|
||||||
|
|
@ -44,7 +44,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = main.o lexor.o
|
O = main.o lexor.o
|
||||||
|
|
|
||||||
|
|
@ -48,7 +48,7 @@ LDRELOCFLAGS = @LDRELOCFLAGS@
|
||||||
LDTARGETFLAGS = @LDTARGETFLAGS@
|
LDTARGETFLAGS = @LDTARGETFLAGS@
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
|
|
||||||
A = a_close.o a_compare_handles.o a_configure.o a_fetch_argc.o \
|
A = a_close.o a_compare_handles.o a_configure.o a_fetch_argc.o \
|
||||||
a_fetch_argv.o a_fetch_dir.o a_fetch_fullname.o a_fetch_location.o \
|
a_fetch_argv.o a_fetch_dir.o a_fetch_fullname.o a_fetch_location.o \
|
||||||
|
|
|
||||||
|
|
@ -370,7 +370,7 @@ PLI_INT32 tf_irosynchronize(void*obj)
|
||||||
vpiHandle sys = (vpiHandle)obj;
|
vpiHandle sys = (vpiHandle)obj;
|
||||||
p_pli_data pli = vpi_get_userdata(sys);
|
p_pli_data pli = vpi_get_userdata(sys);
|
||||||
s_cb_data cb;
|
s_cb_data cb;
|
||||||
s_vpi_time ti = {vpiSuppressTime, 0, 0};
|
s_vpi_time ti = {vpiSuppressTime, 0, 0, 0.0};
|
||||||
|
|
||||||
cb.reason = cbReadOnlySynch;
|
cb.reason = cbReadOnlySynch;
|
||||||
cb.cb_rtn = callback;
|
cb.cb_rtn = callback;
|
||||||
|
|
@ -397,7 +397,7 @@ PLI_INT32 tf_isetrealdelay(double dly, void*obj)
|
||||||
vpiHandle sys = (vpiHandle)obj;
|
vpiHandle sys = (vpiHandle)obj;
|
||||||
p_pli_data pli = vpi_get_userdata(sys);
|
p_pli_data pli = vpi_get_userdata(sys);
|
||||||
s_cb_data cb;
|
s_cb_data cb;
|
||||||
s_vpi_time ti = {vpiSimTime};
|
s_vpi_time ti = {vpiSimTime, 0, 0, 0.0};
|
||||||
|
|
||||||
/* Scale delay to SimTime */
|
/* Scale delay to SimTime */
|
||||||
ivl_u64_t delay = ((dly
|
ivl_u64_t delay = ((dly
|
||||||
|
|
|
||||||
|
|
@ -44,7 +44,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
D = d-generic.o d-generic-edif.o d-lpm.o d-virtex.o d-virtex2.o
|
D = d-generic.o d-generic-edif.o d-lpm.o d-virtex.o d-virtex2.o
|
||||||
|
|
|
||||||
|
|
@ -40,7 +40,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = null.o
|
O = null.o
|
||||||
|
|
|
||||||
|
|
@ -39,7 +39,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = imain.o dump_final.o emit_jed.o enables.o fit_log.o fit_reg.o pads.o
|
O = imain.o dump_final.o emit_jed.o enables.o fit_log.o fit_reg.o pads.o
|
||||||
|
|
|
||||||
|
|
@ -41,7 +41,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = stub.o classes.o constant.o enumerate.o expression.o statement.o switches.o types.o
|
O = stub.o classes.o constant.o enumerate.o expression.o statement.o switches.o types.o
|
||||||
|
|
|
||||||
|
|
@ -39,7 +39,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = @ident_support@ $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = @ident_support@ $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = verilog.o
|
O = verilog.o
|
||||||
|
|
|
||||||
|
|
@ -40,7 +40,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = vlog95.o event.o expr.o logic_lpm.o misc.o numbers.o scope.o stmt.o udp.o
|
O = vlog95.o event.o expr.o logic_lpm.o misc.o numbers.o scope.o stmt.o udp.o
|
||||||
|
|
|
||||||
|
|
@ -44,7 +44,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
O = vvp.o draw_class.o draw_enum.o draw_mux.o draw_net_input.o \
|
O = vvp.o draw_class.o draw_enum.o draw_mux.o draw_net_input.o \
|
||||||
|
|
|
||||||
|
|
@ -51,7 +51,6 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/.. -I$(srcdir)/../libmisc
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
|
||||||
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
LIBS = @LIBS@ @EXTRALIBS@
|
LIBS = @LIBS@ @EXTRALIBS@
|
||||||
|
|
|
||||||
|
|
@ -46,7 +46,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @file64_support@ @CPPFLAGS@ @DEFS@ @PICFLAG@
|
CPPFLAGS = $(INCLUDE_PATH) @file64_support@ @CPPFLAGS@ @DEFS@ @PICFLAG@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
||||||
LDFLAGS = @LDFLAGS@
|
LDFLAGS = @LDFLAGS@
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -33,7 +33,7 @@ includedir = @includedir@
|
||||||
|
|
||||||
# For a cross compile these defines will need to be set accordingly.
|
# For a cross compile these defines will need to be set accordingly.
|
||||||
HOSTCC = @CC@
|
HOSTCC = @CC@
|
||||||
HOSTCFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
HOSTCFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
|
|
||||||
CC = @CC@
|
CC = @CC@
|
||||||
CXX = @CXX@
|
CXX = @CXX@
|
||||||
|
|
@ -56,7 +56,7 @@ INCLUDE_PATH = -I. -I.. -I$(srcdir) -I$(srcdir)/..
|
||||||
endif
|
endif
|
||||||
|
|
||||||
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
CPPFLAGS = $(INCLUDE_PATH) @CPPFLAGS@ @DEFS@
|
||||||
CFLAGS = @WARNING_FLAGS@ @CFLAGS@
|
CFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CC@ @CFLAGS@
|
||||||
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
CXXFLAGS = @WARNING_FLAGS@ @WARNING_FLAGS_CXX@ @CXXFLAGS@
|
||||||
LDFLAGS = @rdynamic@ @LDFLAGS@
|
LDFLAGS = @rdynamic@ @LDFLAGS@
|
||||||
LIBS = @LIBS@ @EXTRALIBS@
|
LIBS = @LIBS@ @EXTRALIBS@
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue