luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix fails to build with -fno-common or gcc-10 

See also: https://bugs.gentoo.org/706366

gcc-10 and above flipped a default from -fcommon to -fno-common:
https://gcc.gnu.org/PR85678

Usually all it takes is to add a few 'extern' declarations and
move definitions from header files to modules. I've port iverilog
to gcc-10 accroding to this guide:
https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

To fix this, I analyzed the code, and found ``pli_trace`` has been
defined at here:
https://github.com/steveicarus/iverilog/blob/v10_3/libveriuser/priv.c#L24

So I changed ``FILE* pli_trace;`` to ``extern FILE* pli_trace;``.

The var ``current_file`` only in ``cfparse_misc.h``, I changed it
from ``char *current_file;`` to ``extern char *current_file;`` and
declaring it in cflexor.lex

And then it works.

Signed-off-by: Huang Rui <vowstar@gmail.com>
This commit is contained in:
Huang Rui 2020-01-29 00:08:59 +08:00
parent 78f12dec1c
commit d49d26a5c5
No known key found for this signature in database
GPG Key ID: AD4E34A8385E3E52
3 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
driver/cflexor.lex
View File

@ -27,6 +27,8 @@
# include "globals.h" # include "globals.h"
# include <string.h> # include <string.h>
char *current_file = NULL;
static int comment_enter; static int comment_enter;
static char* trim_trailing_white(char*txt, int trim); static char* trim_trailing_white(char*txt, int trim);

2
driver/cfparse_misc.h
View File

@ -39,6 +39,6 @@ int cferror(const char *);
int cfparse(void); int cfparse(void);
void switch_to_command_file(const char *); void switch_to_command_file(const char *);
void destroy_lexor(void); void destroy_lexor(void);
char *current_file; extern char *current_file;
#endif /* IVL_cfparse_misc_H */ #endif /* IVL_cfparse_misc_H */

2
libveriuser/priv.h
View File

@ -31,6 +31,6 @@ extern char* __acc_newstring(const char*txt);
/* /*
* Trace file for logging ACC and TF calls. * Trace file for logging ACC and TF calls.
*/ */
FILE* pli_trace; extern FILE* pli_trace;
#endif /* IVL_priv_H */ #endif /* IVL_priv_H */