luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

V0.9: Remove crash for function def with zero args and warn on calls 

Normal Verilog does not allow a function to be defined without at
least an input argument. This patch fixes a crash that was happening
when a function with no arguments was defined. It also adds checks
and prints a descriptive error message when calling a function without
an argument.

The development branch allows this in SV.
This commit is contained in:
Cary R 2012-01-09 19:08:20 -08:00
parent 5f47d660a1
commit c292f77f28
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
parse.y
View File

@ -1,7 +1,7 @@
%{ %{
/* /*
* Copyright (c) 1998-2011 Stephen Williams (steve@icarus.com) * Copyright (c) 1998-2012 Stephen Williams (steve@icarus.com)
* *
* This source code is free software; you can redistribute it * This source code is free software; you can redistribute it
* and/or modify it in source code form under the terms of the GNU * and/or modify it in source code form under the terms of the GNU
@ -1318,6 +1318,16 @@ expr_primary
delete[]$1; delete[]$1;
$$ = tmp; $$ = tmp;
} }
| hierarchy_identifier '(' ')'
{ yyerror(@1, "error: function calls must have at least one "
"input argument.");
yyerrok;
}
| SYSTEM_IDENTIFIER '(' ')'
{ yyerror(@1, "error: system function calls must have at least one "
"input argument.");
yyerrok;
}
/* Many of the VAMS built-in functions are available as builtin /* Many of the VAMS built-in functions are available as builtin
functions with $system_function equivalents. */ functions with $system_function equivalents. */
@ -2396,7 +2406,10 @@ module_item
} }
| K_function automatic_opt function_range_or_type_opt IDENTIFIER error K_endfunction | K_function automatic_opt function_range_or_type_opt IDENTIFIER error K_endfunction
{ {
assert(current_function == 0); if (current_function != 0) {
pform_pop_scope();
current_function = 0;
}
delete[]$4; delete[]$4;
} }