Update some cppcheck suppressions and fix one problem in the code.

Update the line number for a couple cppcheck suppressions and add one for
the pool variable in the vvp directory.

Also move a check for null to the correct place.

cppcheck.sup

@@ -1,3 +1,3 @@
 // These are correct and are used to find the base (zero) pin.
-thisSubtraction:netlist.h:4152
+thisSubtraction:netlist.h:4164
-thisSubtraction:netlist.h:4161
+thisSubtraction:netlist.h:4173

elab_lval.cc

@@ -116,6 +116,11 @@ NetAssign_* PEConcat::elaborate_lval(Design*des,
 
 	    NetAssign_*tmp = parms_[idx]->elaborate_lval(des, scope, is_force);
 
+	      /* If the l-value doesn't elaborate, the error was
+		 already detected and printed. We just skip it and let
+		 the compiler catch more errors. */
+	    if (tmp == 0) continue;
+
 	    if (tmp->expr_type() == IVL_VT_REAL) {
 		  cerr << parms_[idx]->get_fileline() << ": error: "
 		       << "concatenation operand can not be real: "
@@ -124,11 +129,6 @@ NetAssign_* PEConcat::elaborate_lval(Design*des,
 		  continue;
 	    }
 
-	      /* If the l-value doesn't elaborate, the error was
-		 already detected and printed. We just skip it and let
-		 the compiler catch more errors. */
-	    if (tmp == 0) continue;
-
 	      /* Link the new l-value to the previous one. */
 	    NetAssign_*last = tmp;
 	    while (last->more)

vvp/Makefile.in

@@ -99,7 +99,8 @@ distclean: clean
 	rm -f stamp-config-h config.h
 
 cppcheck: $(O:.o=.cc) libvpi.c draw_tt.c
-	cppcheck --enable=all -f $(INCLUDE_PATH) $^
+	cppcheck --enable=all -f --suppressions $(srcdir)/cppcheck.sup \
+	         $(INCLUDE_PATH) $^
 
 Makefile: $(srcdir)/Makefile.in
 	cd ..; ./config.status --file=vvp/$@

vvp/cppcheck.sup

@@ -0,0 +1,3 @@
+// The new() operator is always used to allocate space for this class and
+// pool is defined there.
+uninitVar:vvp_net.cc:153