luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't check for macro redefinition if the warning is disabled. 

And reword the comment to be a bit less dictatorial.
This commit is contained in:
Martin Whitaker 2017-11-06 21:03:03 +00:00
parent e408550d9d
commit af1ea13c47
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ivlpp/lexor.lex
View File

@ -860,17 +860,18 @@ void define_macro(const char* name, const char* value, int keyword, int argc)
struct define_t* def; struct define_t* def;
struct define_t* prev; struct define_t* prev;
/* Verilog spec has a very nasty system of macros jumping from /* Verilog has a very nasty system of macros jumping from
* file to file, resulting in a global macro scope. We abosolutely * file to file, resulting in a global macro scope. Here
* MUST track macro redefinitions and warn user about them. * we optionally warn about any redefinitions.
*/ */
if (warn_redef) {
prev = def_lookup(name); prev = def_lookup(name);
if (prev && warn_redef) { if (prev) {
emit_pathline(istack); emit_pathline(istack);
fprintf(stderr, "warning: redefinition of macro %s from value '%s' to '%s'\n", fprintf(stderr, "warning: redefinition of macro %s from value '%s' to '%s'\n",
name, prev->value, value); name, prev->value, value);
} }
}
def = malloc(sizeof(struct define_t)); def = malloc(sizeof(struct define_t));
def->name = strdup(name); def->name = strdup(name);