luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Initialize LexicalScope::has_parameter_port_list 

The has_parameter_port_list member of the LexicalScope class is not
initialized, which means its default value is undefined. This leads to
random failures where a parameter is marked as non-overridable when it
shouldn't.

Make sure has_parameter_port_list is properly initialized to false.

Fixes: 673b40b78c ("Elaborate `parameter` as non-overridable where required")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
This commit is contained in:
Lars-Peter Clausen 2022-02-19 08:41:53 +01:00
parent cc0a8c8dd2
commit aa905a27cf
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PScope.h
View File

@ -57,7 +57,8 @@ class LexicalScope {
enum lifetime_t { INHERITED, STATIC, AUTOMATIC }; enum lifetime_t { INHERITED, STATIC, AUTOMATIC };
explicit LexicalScope(LexicalScope*parent) explicit LexicalScope(LexicalScope*parent)
: default_lifetime(INHERITED), generate_counter(0), parent_(parent) { } : default_lifetime(INHERITED), has_parameter_port_list(false),
generate_counter(0), parent_(parent) { }
// A virtual destructor is so that dynamic_cast can work. // A virtual destructor is so that dynamic_cast can work.
virtual ~LexicalScope() { } virtual ~LexicalScope() { }