luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Report that forcing a word to/from a variable array in not supported. 

This patch adds error messages that forcing a word to/from a variable
array is not currently supported. This is because variable arrays no
longer are fully populated and don't have an access functor for each
word. Forcing a word from/to a net array does work as expected since
each word in a net array is created.

Technically forcing a variable array word is not supported in 1364-2005.
Reading from an array word, which is supported,  will be fixed in
development once the expression rework is finished.

The error message printed when forcing a bit/part select l-value was
also improved.
This commit is contained in:
Cary R 2011-10-25 19:00:43 -07:00 committed by Stephen Williams
parent b2395aa67e
commit 8bafb18db1
1 changed files with 53 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
tgt-vvp/vvp_process.c
View File

@ -1276,10 +1276,31 @@ static void force_link_rval(ivl_statement_t net, ivl_expr_t rval)
} }
if (ivl_signal_width(lsig) > ivl_signal_width(rsig) || if (ivl_signal_width(lsig) > ivl_signal_width(rsig) ||
(part_off_ex && get_number_immediate(part_off_ex) != 0)) { (part_off_ex && get_number_immediate(part_off_ex) != 0)) {
fprintf(stderr, "%s:%u: tgt-vvp sorry: cannot %s signal to " /* Normalize the bit/part select. */
"a bit/part select.\n", ivl_expr_file(rval), long real_msb = ivl_signal_msb(lsig);
ivl_expr_lineno(rval), command_name); long real_lsb = ivl_signal_lsb(lsig);
exit(1); long use_wid = ivl_signal_width(rsig);
long use_lsb, use_msb;
if (real_msb >= real_lsb) {
use_lsb = get_number_immediate(part_off_ex);
use_lsb += real_lsb;
use_msb = use_lsb + use_wid - 1;
} else {
use_lsb = real_lsb;
use_lsb -= get_number_immediate(part_off_ex);
use_msb = use_lsb;
use_msb -= use_wid - 1;
}
fprintf(stderr, "%s:%u: tgt-vvp sorry: cannot %s signal to a ",
ivl_stmt_file(net), ivl_stmt_lineno(net), command_name);
if (use_wid > 1) {
fprintf(stderr, "part select (%s[%lu:%lu]).\n",
ivl_signal_basename(lsig), use_msb, use_lsb);
} else {
fprintf(stderr, "bit select (%s[%lu]).\n",
ivl_signal_basename(lsig), use_lsb);
}
vvp_errors += 1;
} }
/* At least for now, only handle force to fixed words of an array. */ /* At least for now, only handle force to fixed words of an array. */
@ -1287,17 +1308,42 @@ static void force_link_rval(ivl_statement_t net, ivl_expr_t rval)
assert(number_is_immediate(lword_idx, IMM_WID, 0)); assert(number_is_immediate(lword_idx, IMM_WID, 0));
assert(! number_is_unknown(lword_idx)); assert(! number_is_unknown(lword_idx));
use_lword = get_number_immediate(lword_idx); use_lword = get_number_immediate(lword_idx);
/* We do not currently support using a word from a variable
* array as the L-value (Icarus extension). */
if (ivl_signal_type(lsig) == IVL_SIT_REG) {
/* Normalize the array access. */
long real_word = use_lword;
real_word += ivl_signal_array_base(lsig);
fprintf(stderr, "%s:%u: tgt-vvp sorry: cannot %s to the "
"word of a variable array (%s[%ld]).\n",
ivl_stmt_file(net), ivl_stmt_lineno(net),
command_name, ivl_signal_basename(lsig), real_word);
vvp_errors += 1;
}
} }
if ((rword_idx = ivl_expr_oper1(rval)) != 0) { if ((rword_idx = ivl_expr_oper1(rval)) != 0) {
assert(ivl_signal_dimensions(rsig) != 0);
assert(number_is_immediate(rword_idx, IMM_WID, 0)); assert(number_is_immediate(rword_idx, IMM_WID, 0));
assert(! number_is_unknown(rword_idx)); assert(! number_is_unknown(rword_idx));
use_rword = get_number_immediate(rword_idx); use_rword = get_number_immediate(rword_idx);
/* We do not currently support using a word from a variable
* array as the R-value. */
if (ivl_signal_type(rsig) == IVL_SIT_REG) {
/* Normalize the array access. */
long real_word = use_rword;
real_word += ivl_signal_array_base(rsig);
fprintf(stderr, "%s:%u: tgt-vvp sorry: cannot %s from the "
"word of a variable array (%s[%ld]).\n",
ivl_expr_file(rval), ivl_expr_lineno(rval),
command_name, ivl_signal_basename(rsig), real_word);
vvp_errors += 1;
}
} else {
assert(ivl_signal_dimensions(rsig) == 0);
use_rword = 0;
} }
assert(ivl_signal_dimensions(rsig) == 0);
use_rword = 0;
fprintf(vvp_out, " %s/link", command_name); fprintf(vvp_out, " %s/link", command_name);
fprintf(vvp_out, " v%p_%lu", lsig, use_lword); fprintf(vvp_out, " v%p_%lu", lsig, use_lword);
fprintf(vvp_out, ", v%p_%lu;\n", rsig, use_rword); fprintf(vvp_out, ", v%p_%lu;\n", rsig, use_rword);