luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use a default buffer size of 512 vs 256 for displaying. 

This patch changes the initial buffer size when displaying results
to 512 from 256. This initial buffer is used as the default for the
floating point results and failed when %f is given a large, but
valid value. To make this even more safe we add the precision to
the size to make sure we do not overflow the buffer.
This commit is contained in:
Cary R 2009-06-15 11:11:38 -07:00 committed by Stephen Williams
parent ad419dfbe4
commit 79e0203280
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
vpi/sys_display.c
View File

@ -263,7 +263,7 @@ static unsigned int get_format_char(char **rtn, int ljust, int plus,
s_vpi_value value; s_vpi_value value;
char *result, *fmtb; char *result, *fmtb;
unsigned int size; unsigned int size;
unsigned int ini_size = 256; /* The initial size of the buffer. */ unsigned int ini_size = 512; /* The initial size of the buffer. */
/* Make sure the width fits in the initial buffer. */ /* Make sure the width fits in the initial buffer. */
if (width+1 > ini_size) ini_size = width + 1; if (width+1 > ini_size) ini_size = width + 1;
@ -488,12 +488,15 @@ static unsigned int get_format_char(char **rtn, int ljust, int plus,
/* If the default buffer is too small make it big enough. /* If the default buffer is too small make it big enough.
* *
* This size may not always be correct, but if the default * This should always give enough space. The maximum double
* size is big enough for any practical value then all we * is approximately 1.8*10^308 this means we could need 310
* need to worry about is extra padding and this should work * characters plus the precision. We'll use 320 to give some
* correctly for that case, but since this uses the standard * extra buffer space. The initial buffers size should work
* sprintf() routine we don't know exactly what it will do. */ * for most cases, but to be safe we add the precision to
* the maximum size (think %6.300f when passed 1.2*10^308). */
size = width + 1; size = width + 1;
if (size < 320) size = 320;
size += prec;
if (size > ini_size) result = realloc(result, size*sizeof(char)); if (size > ini_size) result = realloc(result, size*sizeof(char));
sprintf(result, fmtb+1, value.value.real); sprintf(result, fmtb+1, value.value.real);
size = strlen(result) + 1; size = strlen(result) + 1;