luke
/
iverilog
mirror of https://github.com/steveicarus/iverilog.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1392 from larsclausen/fix-negative-packed-slice-width 

Fix width calculation for packed array bounds
This commit is contained in:
Cary R. 2026-06-21 07:20:43 -07:00 committed by GitHub
parent 03f1bbdd37 6326c5b1ba
commit 72833b9570
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 46 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
ivtest/ivltests/sv_partsel_var_negative_packed.v Normal file
View File

@ -0,0 +1,33 @@
// Check variable selects of packed arrays with negative bounds.
module test;
reg failed;
reg [-8:-1][3:0] a;
reg signed [2:0] i;
`define check(val, exp) \
if (val !== exp) begin \
$display("FAILED(%0d). '%s' expected %b, got %b", `__LINE__, \
`"val`", exp, val); \
failed = 1'b1; \
end
initial begin
failed = 1'b0;
a = '0;
i = -1;
a[i] = 4'ha;
i = -2;
a[i] = 4'h5;
`check(a[-1], 4'ha);
`check(a[-2], 4'h5);
if (!failed) begin
$display("PASSED");
end
end
endmodule

1
ivtest/regress-vvp.list
View File

@ -356,6 +356,7 @@ sv_net_decl_assign vvp_tests/sv_net_decl_assign.json
sv_package_lifetime vvp_tests/sv_package_lifetime.json
sv_package_lifetime_fail vvp_tests/sv_package_lifetime_fail.json
sv_parameter_type vvp_tests/sv_parameter_type.json
sv_partsel_var_negative_packed vvp_tests/sv_partsel_var_negative_packed.json
sv_queue_ap_method vvp_tests/sv_queue_ap_method.json
sv_queue_assign_op vvp_tests/sv_queue_assign_op.json
sv_queue_method_insert_too_few_arg_fail vvp_tests/sv_queue_method_insert_too_few_arg_fail.json

8
ivtest/vvp_tests/sv_partsel_var_negative_packed.json Normal file
View File

@ -0,0 +1,8 @@
{
"type" : "normal",
"source" : "sv_partsel_var_negative_packed.v",
"iverilog-args" : [ "-g2005-sv" ],
"vlog95" : {
"iverilog-args" : [ "-pallowsigned=1" ]
}
}

6
netmisc.cc
View File

@ -423,8 +423,10 @@ NetExpr *normalize_variable_slice_base(const list<long>&indices, NetExpr*base,
unsigned min_wid = base->expr_width();
if ((sb < 0) && !base->has_sign()) min_wid += 1;
if (min_wid < num_bits(pcur->get_lsb())) min_wid = pcur->get_lsb();
if (min_wid < num_bits(pcur->get_msb())) min_wid = pcur->get_msb();
if (min_wid < num_bits(pcur->get_lsb()))
min_wid = num_bits(pcur->get_lsb());
if (min_wid < num_bits(pcur->get_msb()))
min_wid = num_bits(pcur->get_msb());
base = pad_to_width(base, min_wid, *base);
if ((sb < 0) && !base->has_sign()) {
NetESelect *tmp = new NetESelect(base, 0 , min_wid);