luke/iverilog
1
0
Fork 0
mirror of https://github.com/steveicarus/iverilog.git synced 2026-08-29 01:03:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve type compatibility checking for dynamic arrays and queues

Browse Source 
SystemVerilog defines different levels of type compatibility.
 * Matching
 * Equivalent
 * Assignment compatible
 * Cast compatible

At the moment the `nettype_t` has only one type compatibility test. It is
used to check assignment compatibility when assigning to a dynamic array,
queue or class.

The current implementation rejects a few cases that should allowed and
allows a few cases that should be rejected.

Dynamic arrays and queues are assignment compatible if their element types
are compatible. And two packed types are equivalent if they are both
2-state or 4-state, both signed or unsigned and have the same packed with.

In the current implementation the sign is not considered and instead of
checking if the packed width is the same it checks that the dimensions are
identical.

Signed-off-by: Lars-Peter Clausen <[email protected]>
This commit is contained in:
Lars-Peter Clausen
2022-10-08 14:01:41 +02:00
parent d4765e3354
commit 5fa1aecd4f
12 changed files with 113 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
netdarray.cc
+15 -11
View File
@@ -37,18 +37,22 @@ ivl_variable_type_t netdarray_t::base_type(void) const
return IVL_VT_DARRAY;
}
bool netdarray_t::test_compatibility(ivl_type_t that) const
bool netdarray_t::test_equivalence(ivl_type_t that) const
{
ivl_type_t elem_type = 0;
if (const netdarray_t*that_da = dynamic_cast<const netdarray_t*>(that))
elem_type = that_da->element_type();
if (const netqueue_t*that_q = dynamic_cast<const netqueue_t*>(that))
elem_type = that_q->element_type();
if (elem_type == 0)
// Queues and dynamic arrays are not equivalent, so check for the base
// type to make sure both are either dynamic array or queue.
if (base_type() != that->base_type())
return false;
return element_type()->type_compatible(elem_type);
return test_compatibility(that);
}
bool netdarray_t::test_compatibility(ivl_type_t that) const
{
// This will match both queues and dynamic arrays
const netdarray_t *that_da = dynamic_cast<const netdarray_t*>(that);
if (!that_da)
return false;
return element_type()->type_equivalent(that_da->element_type());
}