luke
/
OpenSTA
mirror of https://github.com/The-OpenROAD-Project/OpenSTA.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,446 Commits 1 Branch 1 Tag 249 MiB
Commit Graph

2446 Commits

Author SHA1 Message Date
Jaehyun Kim 1d38466776 Remove dead roundtrip comment blocks from SDC tests 
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-03 12:17:55 +09:00
Jaehyun Kim 05e65b1dbf Remove read_sdc roundtrip from all SDC tests 
OpenROAD regression runs 7600+ tests in a shared environment where
clock definitions leak between tests. Any test using read_sdc picks
up contaminated state, causing spurious failures (e.g., clk2 period
15 vs 20). Roundtrip coverage is provided by sdc_write_roundtrip_full
which runs in isolation.

Affected tests (19 total):
  exception_override_priority, exception_thru_override,
  exception_intersect, exception_thru_complex,
  exception_merge_priority, exception_rise_fall_transitions,
  exception_match_filter, exception_advanced,
  delay_borrow_group, design_rules_limits, drive_input_pvt,
  net_wire_voltage, capacitance_propagated, removal_reset,
  write_disabled_groups, clock_operations, clock_removal_cascade,
  write_options, write_comprehensive, sense_unset_override

All 6107 tests pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-03 11:02:08 +09:00
Jaehyun Kim 3561f12c7a Remove SDC roundtrip from exception_override_priority test 
The read_sdc roundtrip section fails in OpenROAD regression because
the shared test environment leaks clock definitions from other tests
(clk2 period 15 vs 20). Roundtrip coverage is already provided by
sdc_write_roundtrip_full which runs in an isolated context.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 21:44:26 +09:00
Matt Liberty 29cea73c3d
Merge pull request #294 from The-OpenROAD-Project-staging/secure-sta-test-by-opus 
Add new Tcl and C++ test cases
 2026-04-02 12:18:17 +00:00
Jaehyun Kim bb186c39dd Remove temporary files 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 20:45:42 +09:00
Jaehyun Kim f192996a42 Update golden files for upstream bias_pins feature 
Upstream added bias pin type recognition, changing VNB/VPB pin
direction from "unknown" to "bias" in liberty output. Update 9
golden .ok files to match.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 12:42:08 +09:00
Jaehyun Kim a22112fe8f Merge remote-tracking branch 'origin/master' into secure-sta-test-by-opus 
# Conflicts:
#	verilog/test/CMakeLists.txt

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 12:30:18 +09:00
Jaehyun Kim ea22794652 Merge remote-tracking branch 'opensta/master' into secure-sta-test-by-opus 
# Conflicts:
#	liberty/TableModel.cc

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 12:21:14 +09:00
Matt Liberty 438633dfa8
Merge pull request #329 from The-OpenROAD-Project-staging/sta_bias_pin_issue_commit_history_correct 
Sta bias pin issue handling, non-determinism in delay calc
 2026-04-02 03:06:57 +00:00
Jaehyun Kim 0e5f14eb37 Revert "Stabilize tests against non-deterministic ordering and version changes" 
This reverts commit d3454bc464.

Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 11:06:36 +09:00
Jaehyun Kim d3454bc464 Stabilize tests against non-deterministic ordering and version changes 
- Use diff_files_sorted for exception_override_priority SDC comparisons
  to handle non-deterministic write_sdc output ordering across environments
- Add (VERSION ignore pattern to SDF diff_files calls so tests don't
  break on upstream version bumps

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-02 10:07:23 +09:00
dsengupta0628 d47cbeb76b fix to exclude bias pins from timing graph 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-04-02 00:56:38 +00:00
dsengupta0628 5e2d5e8ad5 pull latest master, has delay calc non-determinism fix 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-04-02 00:49:47 +00:00
Jaehyun Kim 61bdb83038 Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-04-01 23:54:49 +09:00
James Cherry 70659c2328 PathVisitor::visitFaninPaths filter check edges 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-31 21:03:55 -07:00
James Cherry 638ffa57d4 cleanup 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-31 16:45:47 -07:00
James Cherry 8c1ebce695 GraphDelayCalc::findInputDriverDelay rm finishDrvrPin 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-31 16:37:38 -07:00
James Cherry 9eb9edb0b3 GateTableModel::gateDelay do not clip delays 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-31 14:20:50 -07:00
James Cherry 1d4b516239 GraphDelayCalc::findInputArcDelay thread issue 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-31 13:59:59 -07:00
Matt Liberty 12683d645c
Merge pull request #325 from The-OpenROAD-Project-staging/sta_latest_merge_strings 
update swig file to not use deprecated api and not test it either
 2026-03-31 19:02:49 +00:00
dsengupta0628 b37b37e0d9 update swig file to not use deprecated api and not test it either 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-31 15:50:43 +00:00
Jaehyun Kim 14af24bc93 Ignore SDF VERSION in diff_files to stabilize tests 
Add (VERSION pattern to diff_files ignore parameter so SDF tests
don't break on every upstream version bump. Update golden .ok files
to reflect the now-clean diffs.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-31 22:05:59 +09:00
Jaehyun Kim 3ca78b11c8 Adapt test files to upstream API changes (string_view migration) 
Update 16 test files to match upstream OpenSTA API refactoring:
- const char* → std::string/std::string_view across all test APIs
- EXPECT_STREQ → EXPECT_EQ for std::string/string_view returns
- nullptr → "" for string_view parameters (makeClock, makeClockGroups, etc.)
- PropertyValue("literal") → PropertyValue(std::string("literal")) to avoid
  bool constructor overload resolution
- Method renames: relatedGroundPin→relatedGroundPort,
  relatedPowerPin→relatedPowerPort, firstName→firstParam,
  secondName→secondParam
- Constructor changes: OperatingConditions (5-arg → 1-arg + setters),
  ModeDef::defineValue (3-arg → 1-arg + setSdfCond)
- LibertyAttrValue::floatValue returns std::pair<float,bool> now
- Filter API: separate args → single expression string + bool_props_as_int
- SDF version golden files: 3.0.1 → 3.1.0

All 6104 tests pass.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-31 16:34:40 +09:00
Jaehyun Kim b42e064281 Merge remote-tracking branch 'opensta/master' into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>

# Conflicts:
#	test/get_filter.ok
 2026-03-31 15:29:44 +09:00
Jaehyun Kim 069de0498c Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-31 15:27:01 +09:00
Matt Liberty fe61456df6
Merge pull request #324 from The-OpenROAD-Project-staging/sta_latest_merge_strings 
Sta latest merge strings
 2026-03-31 02:00:13 +00:00
dsengupta0628 6ca7cb55a4 update test infra 2 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-30 21:49:10 +00:00
dsengupta0628 b5f647cb7f update test infra to accomodate std::string instead of const char* 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-30 19:44:26 +00:00
James Cherry 5955958564 findScaleFactorType, findScaleFactorPvt string_view 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-30 11:01:15 -07:00
James Cherry 538db6211f filter_objects via Akash Levy resolves #399 2026-03-30 09:36:21 -07:00
dsengupta0628 5f46ad3dfb Merge remote-tracking branch 'upstream/master' into sta_latest_merge_strings 2026-03-30 16:22:27 +00:00
James Cherry 46472e0eed regresssion update failures/diffs 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-29 15:19:00 -07:00
James Cherry 5aa56bcfee cmake swig 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-29 11:23:26 -07:00
James Cherry 725a6e5e1c require cmake 3.16 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-29 10:56:45 -07:00
James Cherry 3d0b34e88c ReportPath::reportLine 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-29 09:58:06 -07:00
Jaehyun Kim 0a3368e177 Fix non-deterministic SDC write ordering in tests 
Use diff_files_sorted for SDC golden file comparisons in
disable_case and write_roundtrip_full tests. The upstream
set_min_pulse_width output ordering is non-deterministic
due to hash map iteration, causing intermittent CI failures.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-29 23:31:33 +09:00
Jaehyun Kim 2b80a22692 Fix spice tests for upstream write_path_spice API change 
Replace removed -spice_directory flag with -spice_file in all 7
spice test scripts to match the upstream API refactoring.

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-29 23:02:59 +09:00
Jaehyun Kim 422f774b64 Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenSTA into secure-sta-test-by-opus 
Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
 2026-03-29 22:33:08 +09:00
James Cherry 1806e4aede StaTclTypes %include "std_string_view.i" 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-28 19:55:13 -07:00
James Cherry 614385fe51 Liberty unnecessary move 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-28 19:48:21 -07:00
James Cherry ad80dd55b3 cmake show swig version 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-28 19:46:57 -07:00
James Cherry 6742692876 string squash 
Signed-off-by: James Cherry <cherry@parallaxsw.com>
 2026-03-28 19:13:35 -07:00
Matt Liberty 41ad5c62b8
Merge pull request #322 from The-OpenROAD-Project-staging/sta_update_upstream_lvf_stuff 
Sta update upstream lvf stuff
 2026-03-27 23:06:30 +00:00
dsengupta0628 ffda41536f consistent signature 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-27 19:53:13 +00:00
dsengupta0628 c5f5468ca0 more update sta fmp and existing spdlog handling 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-27 19:22:27 +00:00
dsengupta0628 676942555c Merge branch 'master' into sta_update_upstream_lvf_stuff 2026-03-27 19:06:05 +00:00
dsengupta0628 4f288f2cf2 Revert unnecessary change in sta/BUILD 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-27 16:28:12 +00:00
Matt Liberty 01a9c69137
Merge pull request #320 from The-OpenROAD-Project-staging/sta_update_upstream_lvf_stuff 
fix LibertyParser warnings
 2026-03-27 14:56:35 +00:00
dsengupta0628 616280e2f7 fix LibertyParser warnings 
Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
 2026-03-27 01:10:10 +00:00
Matt Liberty 6771b77a5a
Merge pull request #319 from The-OpenROAD-Project-staging/sta_update_upstream_lvf_stuff 
update for succesful bazel build
 2026-03-26 22:49:10 +00:00